Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 819253003: Fix thin rect stroking. (Closed)

Created:
5 years, 11 months ago by f(malita)
Modified:
5 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix thin rect stroking. When both edges of a thin (sub-unit) stroke fall within the same pixel, we compute the wrong coverage and also blit the same line twice. To avoid these issues, tweak the inner/outer hulls to ensure one of the edges is always pixel-aligned. BUG=skia:3278 R=reed@google.com Committed: https://skia.googlesource.com/skia/+/b280646beba5d2d247994f2241b8d0c69a1e031d

Patch Set 1 #

Patch Set 2 : cleanup + gm suppression #

Patch Set 3 : rebased #

Total comments: 2

Patch Set 4 : formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -18 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkScan_Antihair.cpp View 1 2 3 4 chunks +39 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
f(malita)
5 years, 11 months ago (2015-01-05 17:23:29 UTC) #2
reed1
https://codereview.chromium.org/819253003/diff/40001/src/core/SkScan_Antihair.cpp File src/core/SkScan_Antihair.cpp (right): https://codereview.chromium.org/819253003/diff/40001/src/core/SkScan_Antihair.cpp#newcode1001 src/core/SkScan_Antihair.cpp:1001: outer.set(FDot8Floor(outerL), Why the reformat?
5 years, 11 months ago (2015-01-05 17:52:22 UTC) #3
f(malita)
https://codereview.chromium.org/819253003/diff/40001/src/core/SkScan_Antihair.cpp File src/core/SkScan_Antihair.cpp (right): https://codereview.chromium.org/819253003/diff/40001/src/core/SkScan_Antihair.cpp#newcode1001 src/core/SkScan_Antihair.cpp:1001: outer.set(FDot8Floor(outerL), On 2015/01/05 17:52:22, reed1 wrote: > Why the ...
5 years, 11 months ago (2015-01-05 18:48:37 UTC) #4
reed1
lgtm btw -- the new std is 100 cols
5 years, 11 months ago (2015-01-05 19:01:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819253003/60001
5 years, 11 months ago (2015-01-05 19:25:00 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 19:31:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/b280646beba5d2d247994f2241b8d0c69a1e031d

Powered by Google App Engine
This is Rietveld 408576698