Issue 819233002: ui/base: Enable ui_java dep in the GN version ui_base target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 819233002: ui/base: Enable ui_java dep in the GN version ui_base target. (Closed)

Created:
6 years ago by tfarina

Modified:
6 years ago

Reviewers:
brettw, sky

CC:
chromium-reviews, cjhopman, scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

ui/base: Enable ui_java dep in the GN version ui_base target. ui_java target was ported in https://chromium.googlesource.com/chromium/src/+/26046b5fe46738a9c214a64862831e9417f27850 by cjhopman. This patch was tested with the following command lines: $ out/Debug/gn gen out_gn/Debug/ --args='os="android" cpu_arch="arm"' $ ninja -C out_gn/Debug/ ui/base BUG=None TEST=see above TBR=sky@chromium.org,brettw@chromium.org Committed: https://crrev.com/84dbf33e2fcf0be96c8442401b37b61c2bb9aa25 Cr-Commit-Position: refs/heads/master@{#309510}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	ui/base/BUILD.gn	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819233002/1

6 years ago (2014-12-23 00:31:00 UTC) #3

commit-bot: I haz the power

6 years ago (2014-12-23 01:16:11 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/84dbf33e2fcf0be96c8442401b37b61c2bb9aa25
Cr-Commit-Position: refs/heads/master@{#309510}