Issue 81923003: sync: add garbage collection to SessionsSyncManager

Issue 81923003: sync: add garbage collection to SessionsSyncManager (Closed)

Created:
7 years, 1 month ago by tim (not reviewing)

Modified:
7 years ago

Reviewers:
rlarocque

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

sync: add garbage collection to SessionsSyncManager BUG=98892 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238450

Patch Set 3 : Richard's review #

Patch Set 4 : undo last upload #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+185 lines, -18 lines)			Patch
M	chrome/browser/sync/profile_sync_service.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View	1 2 3	3 chunks	+21 lines, -18 lines	0 comments	Download
M	chrome/browser/sync/sessions2/sessions_sync_manager.h	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sessions2/sessions_sync_manager.cc	View	1 2 3	3 chunks	+32 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc	View	1 2 3	10 chunks	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rlarocque

lgtm https://codereview.chromium.org/81923003/diff/70001/chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc File chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc (right): https://codereview.chromium.org/81923003/diff/70001/chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc#newcode1192 chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc:1192: TEST_F(SessionsSyncManagerTest, DoGarbageCollection) { nit: Comment on the purpose ...

7 years, 1 month ago (2013-11-22 01:42:06 UTC) #2

tim (not reviewing)

On 2013/11/22 01:42:06, rlarocque wrote: > lgtm > > https://codereview.chromium.org/81923003/diff/70001/chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc > File chrome/browser/sync/sessions2/sessions_sync_manager_unittest.cc (right): > ...

7 years, 1 month ago (2013-11-22 18:02:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/81923003/210001

7 years ago (2013-12-03 17:06:05 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/81923003/210001

7 years ago (2013-12-03 19:12:22 UTC) #5

Message was sent while issue was closed.

Change committed as 238450

Expand Messages | Collapse Messages