Issue 819213002: Add time to first paint metric to CastMetricsHelper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 819213002: Add time to first paint metric to CastMetricsHelper. (Closed)

Created:
6 years ago by derekjchow1

Modified:
6 years ago

Reviewers:
gunsch

CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org, asvitkine+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add time to first paint metric to CastMetricsHelper. New metrics to record when cast_shell makes an initial paint for a webpage. R=gunsch@chromium.org BUG= Committed: https://crrev.com/0b1cb7b3abf1a823358b3b203d711d0b2d2e8713 Cr-Commit-Position: refs/heads/master@{#309503}

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	chromecast/base/metrics/cast_metrics_helper.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	M	chromecast/base/metrics/cast_metrics_helper.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

gunsch

lgtm As a next step, it'd be interesting a public WebContentsObserver with common functionality, since ...

6 years ago (2014-12-22 23:51:11 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819213002/1

6 years ago (2014-12-22 23:55:28 UTC) #4

commit-bot: I haz the power

6 years ago (2014-12-23 00:39:52 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0b1cb7b3abf1a823358b3b203d711d0b2d2e8713
Cr-Commit-Position: refs/heads/master@{#309503}