Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 819203002: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, tim+watch_chromium.org, hclam+watch_chromium.org, imcheng+watch_chromium.org, zea+watch_chromium.org, chromoting-reviews_chromium.org, posciak+watch_chromium.org, jasonroberts+watch_google.com, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, mikhal+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, hguihot+watch_chromium.org, pvalenzuela+watch_chromium.org, maniscalco+watch_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers jingle/, media/, ppapi/, remoting/, rlz/, skia/, and sync/. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/429bbdd261e1530b951ba528081343d2c9947408 Cr-Commit-Position: refs/heads/master@{#309502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -81 lines) Patch
M jingle/glue/logging_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/alsa/audio_manager_alsa.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_input_stream.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/linux/audio_manager_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M media/audio/win/core_audio_util_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/base/android/browser_cdm_factory_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/mac/avfoundation_glue.mm View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/cast_benchmarks.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/receiver.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/sender.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/cast/test/simulator.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M media/cast/test/utility/input_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/tap_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/cast/test/utility/udp_proxy_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/ffmpeg_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/vpx_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/tools/player_x11/player_x11.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/video/capture/file_video_capture_device_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/mac/video_capture_device_factory_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/video_capture_device_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/video/capture/win/video_capture_device_factory_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/nacl_irt/ppapi_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/pdf_resource.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/proxy/ppp_messaging_proxy_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/ppapi_permissions.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/video_encoder_vpx.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/daemon_process_win.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/host/desktop_session_win.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/wts_session_process_delegate.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M rlz/test/rlz_unittest_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/vector_canvas_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M sync/tools/sync_client.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M sync/tools/sync_listen_notifications.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M sync/tools/testserver/run_sync_testserver.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819203002/1
6 years ago (2014-12-22 23:18:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-23 00:27:59 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-23 00:28:42 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/429bbdd261e1530b951ba528081343d2c9947408
Cr-Commit-Position: refs/heads/master@{#309502}

Powered by Google App Engine
This is Rietveld 408576698