Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Unified Diff: chrome/browser/autofill/autofill_uitest_util.cc

Issue 819193003: Fix list focus after tab key in chrome://settings/autofillEditAddress page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove a couple log statements and add a comment. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/autofill_uitest_util.cc
diff --git a/chrome/browser/autofill/autofill_uitest_util.cc b/chrome/browser/autofill/autofill_uitest_util.cc
new file mode 100644
index 0000000000000000000000000000000000000000..85e560d877af885cb972c91b493399042e17518b
--- /dev/null
+++ b/chrome/browser/autofill/autofill_uitest_util.cc
@@ -0,0 +1,104 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/autofill/autofill_uitest_util.h"
+#include "chrome/browser/autofill/personal_data_manager_factory.h"
+#include "chrome/browser/infobars/infobar_service.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "components/autofill/core/browser/personal_data_manager.h"
+#include "components/autofill/core/browser/personal_data_manager_observer.h"
+#include "components/infobars/core/confirm_infobar_delegate.h"
+#include "components/infobars/core/infobar.h"
+#include "components/infobars/core/infobar_manager.h"
+#include "content/public/test/test_utils.h"
+
+namespace autofill {
+
+// This class is used to wait for asynchronous updates to PersonalDataManager
+// to complete.
+class PdmChangeWaiter
+ : public PersonalDataManagerObserver,
+ public infobars::InfoBarManager::Observer {
+ public:
+ explicit PdmChangeWaiter(Browser* browser)
+ : alerted_(false),
+ has_run_message_loop_(false),
+ browser_(browser),
+ infobar_service_(InfoBarService::FromWebContents(
+ browser_->tab_strip_model()->GetActiveWebContents())) {
+ PersonalDataManagerFactory::GetForProfile(browser_->profile())->
+ AddObserver(this);
+ infobar_service_->AddObserver(this);
+ }
+
+ ~PdmChangeWaiter() override {
+ while (infobar_service_->infobar_count() > 0) {
+ infobar_service_->RemoveInfoBar(infobar_service_->infobar_at(0));
+ }
+ infobar_service_->RemoveObserver(this);
+ }
+
+ // PersonalDataManagerObserver:
+ void OnPersonalDataChanged() override {
+ if (has_run_message_loop_) {
+ base::MessageLoopForUI::current()->Quit();
+ has_run_message_loop_ = false;
+ }
+ alerted_ = true;
+ }
+
+ void OnInsufficientFormData() override { OnPersonalDataChanged(); }
+
+
+ void Wait() {
+ if (!alerted_) {
+ has_run_message_loop_ = true;
+ content::RunMessageLoop();
+ }
+ PersonalDataManagerFactory::GetForProfile(browser_->profile())->
+ RemoveObserver(this);
+ }
+
+ private:
+ // infobars::InfoBarManager::Observer:
+ void OnInfoBarAdded(infobars::InfoBar* infobar) override {
+ infobar_service_->infobar_at(0)->delegate()->AsConfirmInfoBarDelegate()->
+ Accept();
+ }
+
+ bool alerted_;
+ bool has_run_message_loop_;
+ Browser* browser_;
+ InfoBarService* infobar_service_;
+
+ DISALLOW_COPY_AND_ASSIGN(PdmChangeWaiter);
+};
+
+static PersonalDataManager* GetPersonalDataManager(Profile* profile) {
+ return PersonalDataManagerFactory::GetForProfile(profile);
+}
+
+void AddTestProfile(Browser* browser, const AutofillProfile& profile) {
+ PdmChangeWaiter observer(browser);
+ GetPersonalDataManager(browser->profile())->AddProfile(profile);
+
+ // AddProfile is asynchronous. Wait for it to finish before continuing the
+ // tests.
+ observer.Wait();
+}
+
+void SetTestProfile(Browser* browser, const AutofillProfile& profile) {
+ std::vector<AutofillProfile> profiles;
+ profiles.push_back(profile);
+ SetTestProfiles(browser, &profiles);
+}
+
+void SetTestProfiles(Browser* browser, std::vector<AutofillProfile>* profiles) {
+ PdmChangeWaiter observer(browser);
+ GetPersonalDataManager(browser->profile())->SetProfiles(profiles);
+ observer.Wait();
+}
+
+} // namespace autofill
« no previous file with comments | « chrome/browser/autofill/autofill_uitest_util.h ('k') | chrome/browser/resources/options/autofill_options_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698