Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: chrome/browser/autofill/autofill_server_browsertest.cc

Issue 819193003: Fix list focus after tab key in chrome://settings/autofillEditAddress page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove a couple log statements and add a comment. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/macros.h" 5 #include "base/macros.h"
6 #include "base/memory/ref_counted.h" 6 #include "base/memory/ref_counted.h"
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/autofill/personal_data_manager_factory.h" 10 #include "chrome/browser/autofill/personal_data_manager_factory.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/browser/ui/browser.h" 12 #include "chrome/browser/ui/browser.h"
13 #include "chrome/browser/ui/tabs/tab_strip_model.h" 13 #include "chrome/browser/ui/tabs/tab_strip_model.h"
14 #include "chrome/test/base/in_process_browser_test.h" 14 #include "chrome/test/base/in_process_browser_test.h"
15 #include "chrome/test/base/ui_test_utils.h" 15 #include "chrome/test/base/ui_test_utils.h"
16 #include "components/autofill/core/browser/autofill_profile.h" 16 #include "components/autofill/core/browser/autofill_profile.h"
17 #include "components/autofill/core/browser/autofill_test_utils.h" 17 #include "components/autofill/core/browser/autofill_test_utils.h"
18 #include "components/autofill/core/browser/personal_data_manager.h" 18 #include "components/autofill/core/browser/personal_data_manager.h"
19 #include "components/autofill/core/browser/personal_data_manager_observer.h" 19 #include "components/autofill/core/browser/personal_data_manager_observer.h"
20 #include "components/autofill/core/common/autofill_pref_names.h" 20 #include "components/autofill/core/common/autofill_pref_names.h"
21 #include "content/public/test/browser_test_utils.h" 21 #include "content/public/test/browser_test_utils.h"
22 #include "content/public/test/test_utils.h" 22 #include "content/public/test/test_utils.h"
23 #include "net/url_request/test_url_fetcher_factory.h" 23 #include "net/url_request/test_url_fetcher_factory.h"
24 #include "testing/gtest/include/gtest/gtest.h" 24 #include "testing/gtest/include/gtest/gtest.h"
25 25
26 namespace autofill { 26 namespace autofill {
27 namespace { 27 namespace {
28 28
29 // TODO(isherman): Similar classes are defined in a few other Autofill browser 29 // TODO(bondd): PdmChangeWaiter in autofill_uitest_util.cc is a replacement for
30 // tests. It would be good to factor out the shared code into a helper file. 30 // this class. Remove this class and use helper functions in that file instead.
31 class WindowedPersonalDataManagerObserver : public PersonalDataManagerObserver { 31 class WindowedPersonalDataManagerObserver : public PersonalDataManagerObserver {
32 public: 32 public:
33 explicit WindowedPersonalDataManagerObserver(Profile* profile) 33 explicit WindowedPersonalDataManagerObserver(Profile* profile)
34 : profile_(profile), 34 : profile_(profile),
35 message_loop_runner_(new content::MessageLoopRunner){ 35 message_loop_runner_(new content::MessageLoopRunner){
36 PersonalDataManagerFactory::GetForProfile(profile_)->AddObserver(this); 36 PersonalDataManagerFactory::GetForProfile(profile_)->AddObserver(this);
37 } 37 }
38 ~WindowedPersonalDataManagerObserver() override {} 38 ~WindowedPersonalDataManagerObserver() override {}
39 39
40 // Waits for the PersonalDataManager's list of profiles to be updated. 40 // Waits for the PersonalDataManager's list of profiles to be updated.
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 "<field signature=\"116843943\"/>" 191 "<field signature=\"116843943\"/>"
192 "</form>" 192 "</form>"
193 "</autofillquery>"; 193 "</autofillquery>";
194 WindowedNetworkObserver query_network_observer(kQueryRequest); 194 WindowedNetworkObserver query_network_observer(kQueryRequest);
195 ui_test_utils::NavigateToURL( 195 ui_test_utils::NavigateToURL(
196 browser(), GURL(std::string(kDataURIPrefix) + kFormHtml)); 196 browser(), GURL(std::string(kDataURIPrefix) + kFormHtml));
197 query_network_observer.Wait(); 197 query_network_observer.Wait();
198 } 198 }
199 199
200 } // namespace autofill 200 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/autofill/autofill_interactive_uitest.cc ('k') | chrome/browser/autofill/autofill_uitest_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698