Fix list focus after tab key in chrome://settings/autofillEditAddress page.

chrome/browser/resources/options/inline_editable_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var DeletableItemList = options.DeletableItemList;
 
   /**
    * Creates a new list item with support for inline editing.
@@ skipping 67 matching lines @@
       DeletableItem.prototype.decorate.call(this);
 
       this.editFields_ = [];
       this.addEventListener('mousedown', this.handleMouseDown_);
       this.addEventListener('keydown', this.handleKeyDown_);
       this.addEventListener('focusin', this.handleFocusIn_);
     },
 
     /** @override */
     selectionChanged: function() {
-      this.updateEditState();
+      if (!this.parentNode.eventsDisabled)
+        this.updateEditState();
     },
 
     /**
      * Called when this element gains or loses 'lead' status. Updates editing
      * mode accordingly.
      */
     updateLeadState: function() {
       // Add focusability before call to updateEditState.
       if (this.lead) {
         this.setEditableValuesFocusable(true);
@@ skipping 471 matching lines @@
 
   /**
    * @constructor
    * @extends {options.DeletableItemList}
    */
   var InlineEditableItemList = cr.ui.define('list');
 
   InlineEditableItemList.prototype = {
     __proto__: DeletableItemList.prototype,
 
+    // Event handling is disabled if > 0.
+    // @type {number}

[James Hawkins, 2015/01/06 18:54:51]

It's legit now to do:

// @private {number}

But this block should be a JSDoc block:

/**
 * Event handling is disabled if > 0.
 * @private {number}
 */
eventsDisabledCount_: 0,

[bondd, 2015/01/06 23:07:24]

Done. I made it a JSDoc block, but left it as
  * @type {number}
  * @private
rather than
  * @private {number}
to match the existing style in the rest of the file.

+    // @private
+    eventsDisabledCount_: 0,
+
     /**
      * Focuses the input element of the placeholder if true.
      * @type {boolean}
      * @private
      */
     needsToFocusPlaceholder_: false,
 
     /** @override */
     decorate: function() {
       DeletableItemList.prototype.decorate.call(this);
       this.setAttribute('inlineeditable', '');
       this.addEventListener('hasElementFocusChange',
                             this.handleListFocusChange_);
       // <list> isn't focusable by default, but cr.ui.List defaults tabindex to
       // 0 if it's not set.
       this.tabIndex = -1;
     },
 
     /**
+     * Whether events are disabled.
+     * Used to modify the list without triggering a bunch of unnecessary events.
+     * @type {boolean}
+     */
+    get eventsDisabled() {
+      return this.eventsDisabledCount_ > 0;
+    },
+    set eventsDisabled(disabled) {
+      this.eventsDisabledCount_ += disabled ? 1 : -1;
+    },
+
+    /**
      * Called when the list hierarchy as a whole loses or gains focus; starts
      * or ends editing for the lead item if necessary.
      * @param {Event} e The change event.
      * @private
      */
     handleListFocusChange_: function(e) {
+      if (this.eventsDisabled)
+        return;
+
       var leadItem = this.getListItemByIndex(this.selectionModel.leadIndex);
       if (leadItem) {
         if (e.newValue) {
           // Add focusability before making other changes.
           leadItem.setEditableValuesFocusable(true);
           leadItem.setCloseButtonFocusable(true);
           leadItem.focusedColumnIndex = -1;
           leadItem.updateEditState();
           // Remove focusability after making other changes.
           leadItem.setStaticValuesFocusable(false);
         } else {
           // Add focusability before making other changes.
           leadItem.setStaticValuesFocusable(true);
           leadItem.setCloseButtonFocusable(true);
           leadItem.editing = false;
           // Remove focusability after making other changes.
           if (!leadItem.isPlaceholder)
             leadItem.setEditableValuesFocusable(false);
         }
       }
     },
 
     /** @override */
     handleLeadChange: function(e) {
+      if (this.eventsDisabled)
+        return;
+
       DeletableItemList.prototype.handleLeadChange.call(this, e);
 
       var focusedColumnIndex = -1;
       if (e.oldValue != -1) {
         var element = this.getListItemByIndex(e.oldValue);
         if (element) {
           focusedColumnIndex = element.focusedColumnIndex;
           element.updateLeadState();
         }
       }
@@ skipping 19 matching lines @@
         if (item) {
           item.setStaticValuesFocusable(true);
           item.setCloseButtonFocusable(true);
           if (item.isPlaceholder)
             item.setEditableValuesFocusable(true);
         }
       }
     },
 
     /**
+     * Set the selected index without changing the focused element on the page.
+     * Used to change the selected index when the list doesn't have focus (and
+     * doesn't want to take focus).
+     */
+    setSelectedIndexWithoutFocusing: function(index) {
+      this.eventsDisabled = true;
+      // Remove focusability from old item.
+      var oldItem = this.getListItemByIndex(this.selectionModel.leadIndex) ||
+                    this.getInitialFocusableItem();
+      if (oldItem) {
+        oldItem.setEditableValuesFocusable(false);
+        oldItem.setStaticValuesFocusable(false);
+        oldItem.setCloseButtonFocusable(false);
+        oldItem.lead = false;
+      }
+
+      this.selectionModel.selectedIndex = index;
+      // Add focusability to new item.
+      var newItem = this.getListItemByIndex(index);
+      if (newItem) {
+        if (newItem.isPlaceholder)
+          newItem.setEditableValuesFocusable(true);
+        else
+          newItem.setStaticValuesFocusable(true);
+
+        newItem.setCloseButtonFocusable(true);
+        newItem.lead = true;
+      }
+      this.eventsDisabled = false;
+    },
+
+    /**
      * Focus the placeholder's first input field.
      * Should only be called immediately after the list has been repopulated.
      */
     focusPlaceholder: function() {
       // Remove focusability from initial item.
       var item = this.getInitialFocusableItem();
       if (item) {
         item.setStaticValuesFocusable(false);
         item.setCloseButtonFocusable(false);
       }
@@ skipping 29 matching lines @@
           this.getListItemByIndex(0));
     },
   };
 
   // Export
   return {
     InlineEditableItem: InlineEditableItem,
     InlineEditableItemList: InlineEditableItemList,
   };
 });