Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 819193002: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, zea+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers courgette/, dbus/, device/, extensions/, gin/, google_apis/, and gpu/. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/9ab037205876578d14c5686f491c37bab680eccb Cr-Commit-Position: refs/heads/master@{#309490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -119 lines) Patch
M courgette/courgette_tool.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M dbus/test_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/test/usb_test_gadget_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/test/test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/app_window/app_window.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/extension_prefs_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/common/feature_switch.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/features/simple_feature.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/background_info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/common/manifest_handlers/permissions_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/user_script.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/app_window_custom_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/process_info_native_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/app/shell_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/default_shell_browser_main_delegate.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M extensions/shell/browser/shell_browser_main_parts.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_content_browser_client.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M gin/shell/gin_main.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M gin/shell/gin_shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_urls.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M google_apis/google_api_keys.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/angle_end2end_tests_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/angle_unittest_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/unittest_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/async_pixel_transfer_manager_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/context_group.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/feature_info_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 4 chunks +13 lines, -12 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/memory_program_cache.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/shader_translator.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_clear_framebuffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_tests_main.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_driver_bug_list.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_list.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/config/gpu_info_collector_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M gpu/config/gpu_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/gles2_conform_support/egl/egl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/gles2_conform_support/gles2_conform_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/gles2_conform_support/native/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/khronos_glcts_support/khronos_glcts_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/khronos_glcts_support/native/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/tools/compositor_model_bench/compositor_model_bench.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819193002/1
6 years ago (2014-12-22 23:21:16 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 23:50:22 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-22 23:51:17 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9ab037205876578d14c5686f491c37bab680eccb
Cr-Commit-Position: refs/heads/master@{#309490}

Powered by Google App Engine
This is Rietveld 408576698