Issue 819183006: Suppress a use-after-free report in blink::RemoteFrame::detach().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 819183006: Suppress a use-after-free report in blink::RemoteFrame::detach(). (Closed)

Created:
5 years, 11 months ago by Jeffrey Yasskin

Modified:
5 years, 11 months ago

Reviewers:
Nate Chapin

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Suppress a use-after-free report in blink::RemoteFrame::detach(). BUG=432070 TBR=japhet@chromium.org NOTRY=true Committed: https://crrev.com/f54c1207ebe045798603f6484ad1f59aecad061c Cr-Commit-Position: refs/heads/master@{#311154}

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/sanitizers/tsan_suppressions.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819183006/1

5 years, 11 months ago (2015-01-13 00:11:57 UTC) #2

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/f54c1207ebe045798603f6484ad1f59aecad061c Cr-Commit-Position: refs/heads/master@{#311154}

5 years, 11 months ago (2015-01-13 00:14:01 UTC) #4

Łukasz Anforowicz

4 years ago (2016-12-06 20:11:35 UTC) #5

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2555873002/ by lukasza@chromium.org.

The reason for reverting is: Speculative revert - the original problem doesn't
seem to repro anymore (per https://crbug.com/432070#c17) so let's try to remove
the (hopefully) no longer needed test suppression..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages