Add cross-platform resilience to gclient CPU count probe.

Add cross-platform resilience to gclient CPU count probe.

BUG=chromium:444597
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293549

[dnj, 2014-12-22 18:03:20]

dnj@chromium.org changed reviewers:
+ agable@chromium.org, friedman@chromium.org, iannucci@chromium.org

[dnj, 2014-12-22 18:03:20]

PTAL

[dnj, 2014-12-22 18:28:11]

Patchset #1 (id:1) has been deleted

[dpranke, 2014-12-23 17:54:11]

I think this change is misled; see my comments on the bug.

[agable, 2015-01-07 00:11:02]

I think this LGTM. The stack trace in the bug doesn't look like hitting the
system library, it is clearly referencing the 2.7.6 installation inside
depot_tools. And this does match the 2.7 documentation, so I say we land this.

https://codereview.chromium.org/819133003/diff/20001/gclient_utils.py
File gclient_utils.py (right):

https://codereview.chromium.org/819133003/diff/20001/gclient_utils.py#newcode...
gclient_utils.py:1143: try:
This function is now:

try:
  try:
    return
  except:
    pass
  return
except:
  pass
return

Why not

try:
  try:
    return
  except:
    return
except:
  return

?

[dnj, 2015-01-07 00:49:24]

Good point. Can you confirm the new construction?

https://codereview.chromium.org/819133003/diff/20001/gclient_utils.py
File gclient_utils.py (right):

https://codereview.chromium.org/819133003/diff/20001/gclient_utils.py#newcode...
gclient_utils.py:1143: try:
On 2015/01/07 00:11:02, agable wrote:
> This function is now:
> 
> try:
>   try:
>     return
>   except:
>     pass
>   return
> except:
>   pass
> return
> 
> Why not
> 
> try:
>   try:
>     return
>   except:
>     return
> except:
>   return
> 
> ?

I'm generally adverse to large 'except' logic blocks, but sure!

[agable, 2015-01-07 19:35:10]

lgtm

[dnj, 2015-01-07 19:51:20]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2015-01-07 19:52:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819133003/40001

[commit-bot: I haz the power, 2015-01-07 19:54:58]

Committed patchset #2 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293549