Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 819103002: [turbofan] Minor cleanup to reduce code duplication. (Closed)

Created:
5 years, 12 months ago by Benedikt Meurer
Modified:
5 years, 12 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Minor cleanup to reduce code duplication. TEST=unittests R=jochen@chromium.org Committed: https://crrev.com/00013a5692d53b99f934e17d564fcdb10b88f38f Cr-Commit-Position: refs/heads/master@{#25927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -25 lines) Patch
M test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/unittests/compiler/graph-unittest.h View 3 chunks +7 lines, -5 lines 0 comments Download
M test/unittests/compiler/graph-unittest.cc View 2 chunks +14 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/unittests/compiler/simplified-operator-reducer-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 12 months ago (2014-12-22 13:58:44 UTC) #1
Benedikt Meurer
PTAL
5 years, 12 months ago (2014-12-22 13:59:05 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 12 months ago (2014-12-22 14:01:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819103002/1
5 years, 12 months ago (2014-12-22 14:10:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-22 14:37:22 UTC) #6
commit-bot: I haz the power
5 years, 12 months ago (2014-12-22 14:37:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00013a5692d53b99f934e17d564fcdb10b88f38f
Cr-Commit-Position: refs/heads/master@{#25927}

Powered by Google App Engine
This is Rietveld 408576698