Issue 819103002: [turbofan] Minor cleanup to reduce code duplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 819103002: [turbofan] Minor cleanup to reduce code duplication. (Closed)

Created:
5 years, 12 months ago by Benedikt Meurer

Modified:
5 years, 12 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Minor cleanup to reduce code duplication. TEST=unittests R=jochen@chromium.org Committed: https://crrev.com/00013a5692d53b99f934e17d564fcdb10b88f38f Cr-Commit-Position: refs/heads/master@{#25927}

Created: 5 years, 12 months ago

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -25 lines)
M	test/unittests/compiler/change-lowering-unittest.cc	View	1 chunk	+0 lines, -4 lines	0 comments
M	test/unittests/compiler/graph-unittest.h	View	3 chunks	+7 lines, -5 lines	0 comments
M	test/unittests/compiler/graph-unittest.cc	View	2 chunks	+14 lines, -2 lines	0 comments
M	test/unittests/compiler/js-builtin-reducer-unittest.cc	View	1 chunk	+0 lines, -6 lines	0 comments
M	test/unittests/compiler/js-typed-lowering-unittest.cc	View	1 chunk	+0 lines, -6 lines	0 comments
M	test/unittests/compiler/simplified-operator-reducer-unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments

Total messages: 7 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819103002/1

5 years, 12 months ago (2014-12-22 14:10:32 UTC) #5

commit-bot: I haz the power

5 years, 12 months ago (2014-12-22 14:37:34 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/00013a5692d53b99f934e17d564fcdb10b88f38f
Cr-Commit-Position: refs/heads/master@{#25927}