Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 819093002: Deprecate Range.compareNode() and Range.expand() (Closed)

Created:
6 years ago by philipj_slow
Modified:
5 years, 12 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M LayoutTests/fast/dom/Range/detach-range-during-deletecontents-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Range/range-compareNode-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/dom/Range/range-expand-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/multicol/float-truncation-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-lr/float-truncation-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/multicol/vertical-rl/float-truncation-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/text/international/cjk-segmentation-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Range.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
update expectations
6 years ago (2014-12-22 15:17:05 UTC) #1
philipj_slow
PTAL. I'll create a tracking bug and land if there no objections on blink-dev soon.
6 years ago (2014-12-23 08:35:57 UTC) #3
Yuta Kitamura
lgtm
6 years ago (2014-12-24 03:22:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819093002/20001
5 years, 12 months ago (2014-12-27 10:51:03 UTC) #6
commit-bot: I haz the power
5 years, 12 months ago (2014-12-27 11:41:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187726

Powered by Google App Engine
This is Rietveld 408576698