Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: mojo/public/js/struct_unittests.js

Issue 819083005: Update the generator to work around a MSVC limitation. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: With comment Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/js/struct_unittests.js
diff --git a/mojo/public/js/struct_unittests.js b/mojo/public/js/struct_unittests.js
index d91ff4d1623bad23de411cc6e74723a04e6c9990..39a8978139d1c4baa95643fd63567e90e1b07ede 100644
--- a/mojo/public/js/struct_unittests.js
+++ b/mojo/public/js/struct_unittests.js
@@ -189,9 +189,7 @@ define([
}
function testIntegerNumberValues() {
- var minInt32 = -2147483648; // See crbug.com/445618
- var decodedStruct = structEncodeDecode(
- new testStructs.IntegerNumberValues({f10: minInt32}));
+ var decodedStruct = structEncodeDecode(new testStructs.IntegerNumberValues);
expect(decodedStruct.f0).toEqual(testStructs.IntegerNumberValues.V0);
expect(decodedStruct.f1).toEqual(testStructs.IntegerNumberValues.V1);
expect(decodedStruct.f2).toEqual(testStructs.IntegerNumberValues.V2);
@@ -202,7 +200,7 @@ define([
expect(decodedStruct.f7).toEqual(testStructs.IntegerNumberValues.V7);
expect(decodedStruct.f8).toEqual(testStructs.IntegerNumberValues.V8);
expect(decodedStruct.f9).toEqual(testStructs.IntegerNumberValues.V9);
- expect(decodedStruct.f10).toEqual(minInt32);
+ expect(decodedStruct.f10).toEqual(testStructs.IntegerNumberValues.V10);
expect(decodedStruct.f11).toEqual(testStructs.IntegerNumberValues.V11);
expect(decodedStruct.f12).toEqual(testStructs.IntegerNumberValues.V12);
expect(decodedStruct.f13).toEqual(testStructs.IntegerNumberValues.V13);
« no previous file with comments | « mojo/public/interfaces/bindings/tests/test_structs.mojom ('k') | mojo/public/tools/bindings/generators/mojom_cpp_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698