Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc

Issue 819083002: Fix AppModalDialogHelper to deal with a TabStrip without an active tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updates Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc
diff --git a/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc b/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc
index 05b0f921b337ce8ea50b76c848493686d8b99038..345e7a1a4e046278685abe1946b43366590d66c0 100644
--- a/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc
+++ b/chrome/browser/ui/blocked_content/app_modal_dialog_helper.cc
@@ -23,6 +23,7 @@ AppModalDialogHelper::AppModalDialogHelper(content::WebContents* dialog_host)
content::WebContents* active_web_contents =
active_browser->tab_strip_model()->GetActiveWebContents();
if (active_browser->is_type_popup() &&
+ active_web_contents &&
active_web_contents->GetOpener() == dialog_host) {
// It's indeed a popup from the dialog opening WebContents. Store it, so
// we can focus it later.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698