Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 819033002: Work-around to make webkit test suite work with optdebug==2. (Closed)

Created:
6 years ago by Michael Achenbach
Modified:
6 years ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Work-around to make webkit test suite work with optdebug==2. The test driver doesn't know at the moment if optdebug 1 or 2 has been used (the first is used on the bots, the second locally in quickcheck). It can't know therefore if slow asserts can be enabled or not. Trying to enable them leads to a warning if they weren't compiled, which causes webkit 1:1 text comparison to fail. Committed: https://crrev.com/096e1972cd4f2b44130f51d4efe4b3a7b3c4f56f Cr-Commit-Position: refs/heads/master@{#25921}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M test/webkit/testcfg.py View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
6 years ago (2014-12-22 10:06:51 UTC) #2
Benedikt Meurer
Urghs...LGTM
6 years ago (2014-12-22 10:07:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819033002/1
6 years ago (2014-12-22 10:46:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 11:13:08 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-22 11:13:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/096e1972cd4f2b44130f51d4efe4b3a7b3c4f56f
Cr-Commit-Position: refs/heads/master@{#25921}

Powered by Google App Engine
This is Rietveld 408576698