Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 818983002: Revert of Fix crash when the source browser window is deleted during a drag (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
Reviewers:
pkotwicz, sky
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@drag_drop_end_move_loop2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix crash when the source browser window is deleted during a drag (patchset #3 id:160001 of https://codereview.chromium.org/795303002/) Reason for revert: Since landing this, Linux ChromiumOS Ozone Tests (1) is failing three DND tests. http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/7685/steps/interactive_ui_tests/logs/stdio @@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #1):@@@ @@@STEP_LOG_LINE@DND@[ RUN ] BookmarkBarViewTest5.DND@@@ @@@STEP_LOG_LINE@DND@@@@ @@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #2):@@@ @@@STEP_LOG_LINE@DND@[ RUN ] BookmarkBarViewTest5.DND@@@ @@@STEP_LOG_LINE@DND@@@@ @@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #3):@@@ @@@STEP_LOG_LINE@DND@[ RUN ] BookmarkBarViewTest5.DND@@@ @@@STEP_LOG_LINE@DND@@@@ @@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #4):@@@ @@@STEP_LOG_LINE@DND@[ RUN ] BookmarkBarViewTest5.DND@@@ @@@STEP_LOG_LINE@DND@@@@ @@@STEP_LOG_END@DND@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #1):@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN ] BookmarkBarViewTest7.DNDToDifferentMenu@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #2):@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN ] BookmarkBarViewTest7.DNDToDifferentMenu@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #3):@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN ] BookmarkBarViewTest7.DNDToDifferentMenu@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #4):@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN ] BookmarkBarViewTest7.DNDToDifferentMenu@@@ @@@STEP_LOG_LINE@DNDToDifferentMenu@@@@ @@@STEP_LOG_END@DNDToDifferentMenu@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #1):@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #2):@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #3):@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #4):@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@ @@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@ @@@STEP_LOG_END@DNDBackToOriginatingMenu@@@ Original issue's description: > Fix crash when the source browser window is deleted during a drag > > This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if > the browser window is deleted during a drag-drop operation. An extension can > delete the browser window during the drag-drop operation. > > BUG=440534 > TEST=BookmarkBarViewTest22.* > > Committed: https://crrev.com/460bdd69c6f96191a4293da61e9e4999acd0f5ff > Cr-Commit-Position: refs/heads/master@{#309360} TBR=sky@chromium.org,pkotwicz@chromium.org NOTREECHECKS=true NOTRY=true BUG=440534 Committed: https://crrev.com/fc71cba8be820f2616cebe378bdd31106f4f3e64 Cr-Commit-Position: refs/heads/master@{#309367}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -97 lines) Patch
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc View 6 chunks +5 lines, -76 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of Fix crash when the source browser window is deleted during a drag
6 years ago (2014-12-21 00:36:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818983002/1
6 years ago (2014-12-21 00:36:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-21 00:37:39 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-21 00:38:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc71cba8be820f2616cebe378bdd31106f4f3e64
Cr-Commit-Position: refs/heads/master@{#309367}

Powered by Google App Engine
This is Rietveld 408576698