Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6588)

Unified Diff: components/sessions/base_session_service_commands.cc

Issue 818833004: Remove deprecated methods from Pickle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/bookmarks/browser/bookmark_node_data.cc ('k') | components/sessions/session_service_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sessions/base_session_service_commands.cc
diff --git a/components/sessions/base_session_service_commands.cc b/components/sessions/base_session_service_commands.cc
index c0ae0a3d0707e340713742d40b5ce4faf5a93faf..09eab437287d28a19b8cf0f238ceb5aaf5bc2af9 100644
--- a/components/sessions/base_session_service_commands.cc
+++ b/components/sessions/base_session_service_commands.cc
@@ -109,8 +109,7 @@ bool RestoreUpdateTabNavigationCommand(
if (!pickle.get())
return false;
PickleIterator iterator(*pickle);
- return pickle->ReadInt(&iterator, tab_id) &&
- navigation->ReadFromPickle(&iterator);
+ return iterator.ReadInt(tab_id) && navigation->ReadFromPickle(&iterator);
}
bool RestoreSetTabExtensionAppIDCommand(const SessionCommand& command,
@@ -121,8 +120,7 @@ bool RestoreSetTabExtensionAppIDCommand(const SessionCommand& command,
return false;
PickleIterator iterator(*pickle);
- return pickle->ReadInt(&iterator, tab_id) &&
- pickle->ReadString(&iterator, extension_app_id);
+ return iterator.ReadInt(tab_id) && iterator.ReadString(extension_app_id);
}
bool RestoreSetTabUserAgentOverrideCommand(const SessionCommand& command,
@@ -133,8 +131,7 @@ bool RestoreSetTabUserAgentOverrideCommand(const SessionCommand& command,
return false;
PickleIterator iterator(*pickle);
- return pickle->ReadInt(&iterator, tab_id) &&
- pickle->ReadString(&iterator, user_agent_override);
+ return iterator.ReadInt(tab_id) && iterator.ReadString(user_agent_override);
}
bool RestoreSetWindowAppNameCommand(const SessionCommand& command,
@@ -145,8 +142,7 @@ bool RestoreSetWindowAppNameCommand(const SessionCommand& command,
return false;
PickleIterator iterator(*pickle);
- return pickle->ReadInt(&iterator, window_id) &&
- pickle->ReadString(&iterator, app_name);
+ return iterator.ReadInt(window_id) && iterator.ReadString(app_name);
}
} // namespace sessions
« no previous file with comments | « components/bookmarks/browser/bookmark_node_data.cc ('k') | components/sessions/session_service_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698