Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 818803004: Fix GPU process crash in ChromecastShellBrowserTest.EmptyTest (Closed)

Created:
5 years, 11 months ago by halliwell
Modified:
5 years, 11 months ago
Reviewers:
byungchul, gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GPU process crash in ChromecastShellBrowserTest.EmptyTest Using --disable-gpu to fix the GPU process crash. Unfortunately this exposed a different crash in our teardown process. For now, I've removed the test code that shuts down render processes. The problem with this is Chromecast code reacts to the render process dying and tries to start the error screen just as it's about to be shut down. This ultimately leads to a crash. Chromecast code shuts down the render processes itself, so I don't believe we need the FastShutdownIfPossible calls in this test. BUG= Committed: https://crrev.com/dfffeb6a4d6f834ef553fcdbaf0367df8b5437c0 Cr-Commit-Position: refs/heads/master@{#311801}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chromecast/browser/test/chromecast_browser_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chromecast/chromecast_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
halliwell
5 years, 11 months ago (2015-01-15 22:51:29 UTC) #2
gunsch
lgtm
5 years, 11 months ago (2015-01-15 22:55:36 UTC) #3
gunsch
lgtm
5 years, 11 months ago (2015-01-15 22:55:37 UTC) #4
byungchul
lgtm
5 years, 11 months ago (2015-01-15 23:08:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818803004/1
5 years, 11 months ago (2015-01-15 23:09:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:56:51 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:58:13 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfffeb6a4d6f834ef553fcdbaf0367df8b5437c0
Cr-Commit-Position: refs/heads/master@{#311801}

Powered by Google App Engine
This is Rietveld 408576698