Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 818793002: [Ozone] Fix build dependencies in ui/base (Closed)

Created:
6 years ago by dnicoara
Modified:
6 years ago
Reviewers:
sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone] Fix build dependencies in ui/base BUG=none TBR=sadrul@chromium.org Committed: https://crrev.com/114899dbe07dda291696368e539eedb4317241e3 Cr-Commit-Position: refs/heads/master@{#309261}

Patch Set 1 #

Patch Set 2 : simplify #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M ui/base/BUILD.gn View 1 1 chunk +4 lines, -1 line 1 comment Download
M ui/base/ui_base.gyp View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 8 (2 generated)
dnicoara
Fixing the ECS Ozone bot which broke after https://codereview.chromium.org/806693008 added a dependency on ui/events/devices.
6 years ago (2014-12-19 19:20:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818793002/20001
6 years ago (2014-12-19 20:49:21 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-19 21:13:50 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/114899dbe07dda291696368e539eedb4317241e3 Cr-Commit-Position: refs/heads/master@{#309261}
6 years ago (2014-12-19 21:14:41 UTC) #6
sadrul
lgtm https://codereview.chromium.org/818793002/diff/20001/ui/base/BUILD.gn File ui/base/BUILD.gn (right): https://codereview.chromium.org/818793002/diff/20001/ui/base/BUILD.gn#newcode608 ui/base/BUILD.gn:608: ] Sort https://codereview.chromium.org/818793002/diff/20001/ui/base/ui_base.gyp File ui/base/ui_base.gyp (right): https://codereview.chromium.org/818793002/diff/20001/ui/base/ui_base.gyp#newcode479 ui/base/ui_base.gyp:479: ...
6 years ago (2014-12-19 21:40:48 UTC) #7
dnicoara
6 years ago (2014-12-19 21:43:56 UTC) #8
Message was sent while issue was closed. 
On 2014/12/19 21:40:48, sadrul wrote:
> lgtm
> 
> https://codereview.chromium.org/818793002/diff/20001/ui/base/BUILD.gn
> File ui/base/BUILD.gn (right):
> 
>
https://codereview.chromium.org/818793002/diff/20001/ui/base/BUILD.gn#newcode608
> ui/base/BUILD.gn:608: ]
> Sort
> 
> https://codereview.chromium.org/818793002/diff/20001/ui/base/ui_base.gyp
> File ui/base/ui_base.gyp (right):
> 
>
https://codereview.chromium.org/818793002/diff/20001/ui/base/ui_base.gyp#newc...
> ui/base/ui_base.gyp:479:
'../events/devices/events_devices.gyp:events_devices',
> Sort

Doh :( ... I'm sorry I forgot to sort, I'll sort them in the followup I have.

Powered by Google App Engine
This is Rietveld 408576698