Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 818773005: [DevTools] Skip WebView instances without open pages (Closed)

Created:
5 years, 11 months ago by vkuzkokov
Modified:
5 years, 11 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Skip WebView instances without open pages BUG=448707 Committed: https://crrev.com/05ffc6b5332c5db8c4e7d043ed4cbed931c4b5b1 Cr-Commit-Position: refs/heads/master@{#311492}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -35 lines) Patch
M chrome/browser/resources/inspect/inspect.js View 1 2 6 chunks +44 lines, -35 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
vkuzkokov
5 years, 11 months ago (2015-01-14 14:07:40 UTC) #3
dgozman
https://codereview.chromium.org/818773005/diff/20001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): https://codereview.chromium.org/818773005/diff/20001/chrome/browser/resources/inspect/inspect.js#newcode27 chrome/browser/resources/inspect/inspect.js:27: if ('trace' in queryParamsObject || 'tracing' in queryParamsObject) { ...
5 years, 11 months ago (2015-01-14 14:12:01 UTC) #4
vkuzkokov
https://codereview.chromium.org/818773005/diff/20001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): https://codereview.chromium.org/818773005/diff/20001/chrome/browser/resources/inspect/inspect.js#newcode27 chrome/browser/resources/inspect/inspect.js:27: if ('trace' in queryParamsObject || 'tracing' in queryParamsObject) { ...
5 years, 11 months ago (2015-01-14 15:01:21 UTC) #5
dgozman
lgtm https://codereview.chromium.org/818773005/diff/40001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): https://codereview.chromium.org/818773005/diff/40001/chrome/browser/resources/inspect/inspect.js#newcode150 chrome/browser/resources/inspect/inspect.js:150: icon.hidden; (!icon || icon.hidden)
5 years, 11 months ago (2015-01-14 15:17:41 UTC) #6
vkuzkokov
https://codereview.chromium.org/818773005/diff/40001/chrome/browser/resources/inspect/inspect.js File chrome/browser/resources/inspect/inspect.js (right): https://codereview.chromium.org/818773005/diff/40001/chrome/browser/resources/inspect/inspect.js#newcode150 chrome/browser/resources/inspect/inspect.js:150: icon.hidden; On 2015/01/14 15:17:40, dgozman wrote: > (!icon || ...
5 years, 11 months ago (2015-01-14 15:19:42 UTC) #7
vkuzkokov
Pavel, PTAL
5 years, 11 months ago (2015-01-14 15:20:13 UTC) #9
pfeldman
lgtm
5 years, 11 months ago (2015-01-14 15:43:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818773005/60001
5 years, 11 months ago (2015-01-14 15:45:48 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 11 months ago (2015-01-14 16:41:34 UTC) #13
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 16:42:41 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/05ffc6b5332c5db8c4e7d043ed4cbed931c4b5b1
Cr-Commit-Position: refs/heads/master@{#311492}

Powered by Google App Engine
This is Rietveld 408576698