Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: runtime/observatory/lib/service_common.dart

Issue 818733002: Rank most retaining instances for each class. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/service.dart ('k') | runtime/observatory/lib/src/app/application.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/service_common.dart
===================================================================
--- runtime/observatory/lib/service_common.dart (revision 42649)
+++ runtime/observatory/lib/service_common.dart (working copy)
@@ -172,7 +172,9 @@
_webSocket.nonStringToByteData(data).then((ByteData bytes) {
// See format spec. in VMs Service::SendEvent.
int offset = 0;
- int metaSize = bytes.getUint64(offset, Endianness.BIG_ENDIAN);
+ // Dart2JS workaround (no getUint64). Limit to 4 GB metadata.
+ assert(bytes.getUint32(offset, Endianness.BIG_ENDIAN) == 0);
+ int metaSize = bytes.getUint32(offset + 4, Endianness.BIG_ENDIAN);
offset += 8;
var meta = _utf8Decoder.convert(new Uint8List.view(
bytes.buffer, bytes.offsetInBytes + offset, metaSize));
« no previous file with comments | « runtime/observatory/lib/service.dart ('k') | runtime/observatory/lib/src/app/application.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698