Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1819)

Unified Diff: runtime/observatory/lib/src/elements/class_view.html

Issue 818733002: Rank most retaining instances for each class. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/class_view.html
===================================================================
--- runtime/observatory/lib/src/elements/class_view.html (revision 42649)
+++ runtime/observatory/lib/src/elements/class_view.html (working copy)
@@ -178,6 +178,21 @@
</template>
</div>
</div>
+ <div class="memberItem">
+ <div class="memberName">most retaining objects</div>
Cutch 2015/01/07 00:25:26 I think this needs more explanation for developers
koda 2015/01/09 18:46:55 Since it's in a class view, under subheading 'inst
+ <div class="memberValue">
+ <template if="{{ mostRetained == null }}">
+ <eval-link callback="{{ retainedToplist }}"
+ label="[find]">
+ </eval-link>
+ </template>
+ <template if="{{ mostRetained != null }}">
+ <template repeat="{{ most in mostRetained }}">
+ {{ most.retainedSize | formatSize }}<instance-ref ref="{{ most }}"></instance-ref><br>
+ </template>
+ </template>
+ </div>
+ </div>
</template>
</div>

Powered by Google App Engine
This is Rietveld 408576698