Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 818703002: Add dependencies for building nacl_helper_nonsfi for ARM. (Closed)

Created:
6 years ago by mazda
Modified:
6 years ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add dependencies for building nacl_helper_nonsfi for ARM. BUG=433201 Committed: https://crrev.com/14099e62fe6ab699dc9c17f7a3ccedcb796eeee3 Cr-Commit-Position: refs/heads/master@{#309210}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M components/nacl_nonsfi.gyp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
mazda
PTAL This CL was split from https://codereview.chromium.org/794573002/ preparing for the NaCl side change https://codereview.chromium.org/771593002/. Thanks,
6 years ago (2014-12-19 15:48:31 UTC) #2
Mark Seaborn
LGTM. By the way, for Chromium-side changes you can use "BUG=12345".
6 years ago (2014-12-19 16:00:38 UTC) #3
mazda
> By the way, for Chromium-side changes you can use "BUG=12345". Fixed. Thanks.
6 years ago (2014-12-19 16:09:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818703002/1
6 years ago (2014-12-19 16:10:15 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-19 16:22:24 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-19 16:23:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14099e62fe6ab699dc9c17f7a3ccedcb796eeee3
Cr-Commit-Position: refs/heads/master@{#309210}

Powered by Google App Engine
This is Rietveld 408576698