Issue 818673004: Explicitly dispose of async call chains.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 818673004: Explicitly dispose of async call chains. (Closed)

Created:
5 years, 12 months ago by sof

Modified:
5 years, 12 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Explicitly dispose of async call chains. When resetting V8AsyncCallTracker's call chains, promptly dispose of the call chain map; Oilpan friendly not to delay it until the dtor is eventually invoked. R=yurys BUG=443585 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187723

Patch Set 1 #

Created: 5 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -5 lines)			Patch
M	Source/core/inspector/AsyncCallChainMap.h	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorDebuggerAgent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/V8AsyncCallTracker.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	Source/core/inspector/V8AsyncCallTracker.cpp	View	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818673004/1

5 years, 12 months ago (2014-12-26 13:59:58 UTC) #4

commit-bot: I haz the power

5 years, 12 months ago (2014-12-26 14:20:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187723

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages