Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 818653004: [Oilpan] Count all GC marking events in tests (Closed)

Created:
5 years, 11 months ago by peria
Modified:
5 years, 11 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed to check if either precise GC or conservative GC events run in tests. Updating Oilpan's infrastructure, its behavior may change. We expect that a GC runs in this test, but we cannot promise that it is a precise GC. Background: We expected precise GC ran in those tests, but at some point, they changed to call conservative GCs. BUG=446301 TEST=./tools/perf/run_tests --browser=content-shell-release OilpanGCTimesTest Committed: https://crrev.com/c326dd5aa4f62e44e97350248dbb1ebaf684af68 Cr-Commit-Position: refs/heads/master@{#310111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M tools/perf/measurements/oilpan_gc_times_unittest.py View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
peria
PTL After this CL is landed, I will re-enable oilpan performance tests.
5 years, 11 months ago (2015-01-06 06:28:23 UTC) #2
kouhei (in TOK)
On 2015/01/06 06:28:23, peria wrote: > PTL > > After this CL is landed, I ...
5 years, 11 months ago (2015-01-06 06:32:44 UTC) #3
haraken
LGTM, thanks for the fix.
5 years, 11 months ago (2015-01-06 06:39:27 UTC) #4
tonyg
lgtm
5 years, 11 months ago (2015-01-06 16:47:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818653004/1
5 years, 11 months ago (2015-01-06 16:47:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 18:15:15 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 18:16:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c326dd5aa4f62e44e97350248dbb1ebaf684af68
Cr-Commit-Position: refs/heads/master@{#310111}

Powered by Google App Engine
This is Rietveld 408576698