Issue 81863002: Sticky keys modifies an entire scroll sequence instead of just a single event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 81863002: Sticky keys modifies an entire scroll sequence instead of just a single event. (Closed)

Created:
7 years ago by Tim Song

Modified:
7 years ago

Reviewers:
sadrul, sky

CC:
Seigo Nonaka, chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sticky keys modifies an entire scroll sequence instead of just a single event. A scroll sequence starts with a fling cancel, followed by a series of scroll events and ends with a fling start event. In the oneshot sticky keys case, we now modify the entire sequence with the modifier key before disabling sticky keys. BUG=308662 TEST=updated unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236834

Patch Set 1 #

Patch Set 2 : rebasing #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+197 lines, -37 lines)			Patch
M	ash/wm/sticky_keys.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	ash/wm/sticky_keys.cc	View	3 chunks	+22 lines, -3 lines	0 comments	Download
M	ash/wm/sticky_keys_unittest.cc	View	5 chunks	+97 lines, -15 lines	0 comments	Download
M	ui/events/x/events_x_utils.h	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	ui/events/x/events_x_utils.cc	View	6 chunks	+62 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/81863002/60001

7 years ago (2013-11-22 18:25:51 UTC) #4

Message was sent while issue was closed.

Change committed as 236834

Expand Messages | Collapse Messages