Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: chrome/browser/dom_ui/new_tab_ui.cc

Issue 8186: Plumb the referrer throughout the OpenURL APIs.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 12 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.h ('k') | chrome/browser/download/download_request_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/dom_ui/new_tab_ui.cc
===================================================================
--- chrome/browser/dom_ui/new_tab_ui.cc (revision 3991)
+++ chrome/browser/dom_ui/new_tab_ui.cc (working copy)
@@ -455,7 +455,7 @@
// Load the URL.
if (!url.empty()) {
- dom_ui_host_->OpenURL(GURL(WideToUTF8(url)), CURRENT_TAB,
+ dom_ui_host_->OpenURL(GURL(WideToUTF8(url)), GURL(), CURRENT_TAB,
PageTransition::LINK);
}
}
@@ -669,7 +669,7 @@
void HistoryHandler::HandleShowHistoryPage(const Value*) {
NavigationController* controller = dom_ui_host_->controller();
if (controller)
- controller->LoadURL(HistoryTabUI::GetURL(), PageTransition::LINK);
+ controller->LoadURL(HistoryTabUI::GetURL(), GURL(), PageTransition::LINK);
}
void HistoryHandler::HandleSearchHistoryPage(const Value* content) {
@@ -685,6 +685,7 @@
NavigationController* controller = dom_ui_host_->controller();
controller->LoadURL(
HistoryTabUI::GetHistoryURLWithSearchText(wstring_value),
+ GURL(),
PageTransition::LINK);
}
}
@@ -803,13 +804,14 @@
}
void NewTabUIContents::RequestOpenURL(const GURL& url,
+ const GURL& /*referrer*/,
WindowOpenDisposition disposition) {
// The user opened a URL on the page (including "open in new window").
// We count all such clicks as AUTO_BOOKMARK, which increments the site's
// visit count (which is used for ranking the most visited entries).
// Note this means we're including clicks on not only most visited thumbnails,
// but also clicks on recently bookmarked.
- OpenURL(url, disposition, PageTransition::AUTO_BOOKMARK);
+ OpenURL(url, GURL(), disposition, PageTransition::AUTO_BOOKMARK);
// Figure out if this was a click on a MostVisited entry, and log it if so.
if (most_visited_handler_) {
« no previous file with comments | « chrome/browser/dom_ui/new_tab_ui.h ('k') | chrome/browser/download/download_request_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698