Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 8186: Plumb the referrer throughout the OpenURL APIs.... (Closed)

Created:
12 years, 1 month ago by eroman
Modified:
9 years, 6 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Plumb the referrer throughout the OpenURL APIs. http://code.google.com/p/chromium/issues/detail?id=3224 Caveats: * Did not update TabNavigation yet. Hence session restore will continue to load the tabs with empty referrer. * Did not plumb referrer into incognito url open. (Not sure what the right thing to do is here with respect to privacy vs compatibility.) * Did not plumb referrer throughout the automation controller. No functional impact here, but it makes the code inconsistent with the non-automation version. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4036

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+271 lines, -179 lines) Patch
M chrome/browser/automation/automation_provider.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/back_forward_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmark_bar_context_menu_controller.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/bookmark_bar_context_menu_controller_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser.h View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/browser.cc View 1 2 13 chunks +22 lines, -19 lines 0 comments Download
M chrome/browser/browser_commands.cc View 6 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/browser_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/constrained_window.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/debugger_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/debugger/debugger_view.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/new_tab_ui.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/download/download_request_manager_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/external_tab_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/external_tab_container.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/history_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/native_ui_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/navigation_controller.h View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/navigation_controller.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/navigation_controller_unittest.cc View 25 chunks +43 lines, -37 lines 0 comments Download
M chrome/browser/navigation_entry.h View 1 3 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/navigation_entry.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/page_navigator.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/render_view_context_menu_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/render_view_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/render_view_host.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/render_view_host_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_blocking_page.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/session_restore.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/site_instance_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/tab_contents.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents_delegate.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/task_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/about_chrome_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bookmark_bar_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_bar_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/bug_report_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/constrained_window_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/constrained_window_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/dom_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/views/html_dialog_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/html_dialog_view.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/views/info_bar_alternate_nav_url_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/views/options/advanced_contents_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/tabs/dragged_tab_controller.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/web_contents_unittest.cc View 31 chunks +37 lines, -37 lines 0 comments Download
M chrome/browser/web_drop_target.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/render_messages.h View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/render_messages_internal.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/render_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/render_view.cc View 4 chunks +9 lines, -3 lines 0 comments Download
M webkit/glue/glue_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/glue_util.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M webkit/glue/webframeloaderclient_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/glue/webview_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/tools/test_shell/test_webview_delegate.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eroman
12 years, 1 month ago (2008-10-27 06:09:30 UTC) #1
darin (slow to review)
LGTM http://codereview.chromium.org/8186/diff/1/37 File chrome/browser/navigation_entry.h (right): http://codereview.chromium.org/8186/diff/1/37#newcode375 Line 375: // TODO(eroman): heed the warning and add ...
12 years, 1 month ago (2008-10-27 07:09:14 UTC) #2
eroman
12 years, 1 month ago (2008-10-27 18:31:42 UTC) #3
http://codereview.chromium.org/8186/diff/1/37
File chrome/browser/navigation_entry.h (right):

http://codereview.chromium.org/8186/diff/1/37#newcode375
Line 375: // TODO(eroman): heed the warning and add this to session restore.
On 2008/10/27 07:09:15, darin wrote:
> please file a bug and talk to sky about this before committing the patch :)

Done.

Filed http://code.google.com/p/chromium/issues/detail?id=3774

I decided against making the changes directly in this CL, since it is already
quite thick (67 files).

Powered by Google App Engine
This is Rietveld 408576698