Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 818573002: Add CloseStdinAndStdout() (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add CloseStdinAndStdout(). There will be no reason to leave the handler process connected to its invoker’s stdin or stdout. On the other hand, I’m currently leaving it connected to the original and stderr, as these may be useful for diagnostics. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/25c3afaac52cb5a63e00b60203bba142aaf4c0a4

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A util/posix/close_stdio.h View 1 1 chunk +42 lines, -0 lines 0 comments Download
A util/posix/close_stdio.cc View 1 chunk +52 lines, -0 lines 0 comments Download
M util/util.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Mark Mentovai
This was broken out from the handler, which is a work-in-progress at https://codereview.chromium.org/798743003/. handler/mac/main.cc calls ...
6 years ago (2014-12-18 23:20:42 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/818573002/diff/1/util/posix/close_stdio.h File util/posix/close_stdio.h (right): https://codereview.chromium.org/818573002/diff/1/util/posix/close_stdio.h#newcode20 util/posix/close_stdio.h:20: //! \brief Closes `stdin` and `stdout` by opening ...
6 years ago (2014-12-19 18:12:05 UTC) #3
Mark Mentovai
Updated.
6 years ago (2014-12-19 19:20:17 UTC) #4
Mark Mentovai
6 years ago (2014-12-19 19:20:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
25c3afaac52cb5a63e00b60203bba142aaf4c0a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698