Android: UMA histogram for coldstart-to-commit

Android: UMA histogram for coldstart-to-commit

This user perceived latency histogram should reflect the time from a browser
cold start to the moment the first navigation is committed: the progress bar
appears and the omnibox draws artifacts of the URL.

BUG=436960
Committed: https://crrev.com/45181af517b696b9495ad8639a5ac7d0212f2280
Cr-Commit-Position: refs/heads/master@{#310761}

[pasko, 2014-12-18 21:27:27]

Patchset #1 (id:1) has been deleted

[Miguel Garcia, 2014-12-22 14:47:05]

miguelg@chromium.org changed reviewers:
+ miguelg@chromium.org

[Miguel Garcia, 2014-12-22 14:47:05]

https://codereview.chromium.org/818513002/diff/40001/chrome/android/java/src/...
File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):

https://codereview.chromium.org/818513002/diff/40001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/Tab.java:398:
UmaUtils.setRunningApplicationStart(false);
Where do you call UmaUtils.setRunningApplicationStart(true); ?

[pasko, 2014-12-22 15:05:53]

On 2014/12/22 14:47:05, Miguel Garcia wrote:
>
https://codereview.chromium.org/818513002/diff/40001/chrome/android/java/src/...
> File chrome/android/java/src/org/chromium/chrome/browser/Tab.java (right):
> 
>
https://codereview.chromium.org/818513002/diff/40001/chrome/android/java/src/...
> chrome/android/java/src/org/chromium/chrome/browser/Tab.java:398:
> UmaUtils.setRunningApplicationStart(false);
> Where do you call UmaUtils.setRunningApplicationStart(true); ?

Thanks for looking into it,

I run it downstream, as Grace suggested in the bug:
https://chrome-internal-review.googlesource.com/#/c/189735/

[Miguel Garcia, 2014-12-22 15:13:06]

lgtm % comment

ahh downstream

can you perhaps add something to chromeshell in this same patch? Just so that
there is a full upstream version that uses the whole flow.

I don't even know if ChromeSell supports UMA so only do it if it's easy

[pasko, 2014-12-22 16:05:45]

On 2014/12/22 15:13:06, Miguel Garcia wrote:
> lgtm % comment
> 
> ahh downstream
> 
> can you perhaps add something to chromeshell in this same patch? Just so that
> there is a full upstream version that uses the whole flow.

Good idea, I subscribed all application starts to recording this histogram in
ChromeShellApplication (which is not inherited from any Android Application used
in Chrome).

[pasko, 2014-12-22 16:07:47]

pasko@chromium.org changed reviewers:
+ isherman@chromium.org

[pasko, 2014-12-22 16:19:29]

isherman: PTaL

This is introducing an Android-specific histogram for application startup. (See
my comment above for the link to downstream code). The histogram itself covers a
very broad range of events, which would make it non-actionable directly). We
intentionally want to keep it this way to:
1. have an end-to-end metric for user-visible startup (tracking overall
progress)
2. make sure that we did not forget to introduce smaller actionable metrics to
cover startup-related work being done in the browser process

We may want to extend this histogram for other platforms, but now it's just an
urgent one only for Android.

[pasko, 2014-12-22 16:19:50]

pasko@chromium.org changed reviewers:
+ klobag@chromium.org

[pasko, 2014-12-22 16:20:38]

klobag: FYI

[Ilya Sherman, 2015-01-06 02:11:09]

histograms lgtm, thanks

[pasko, 2015-01-08 19:05:53]

The CQ bit was checked by pasko@chromium.org

[commit-bot: I haz the power, 2015-01-08 19:07:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818513002/60001

[commit-bot: I haz the power, 2015-01-08 19:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 19:15:19]

Try jobs failed on following builders:
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[pasko, 2015-01-09 11:05:12]

The CQ bit was checked by pasko@chromium.org

[commit-bot: I haz the power, 2015-01-09 11:05:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818513002/80001

[commit-bot: I haz the power, 2015-01-09 12:13:09]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-01-09 12:14:47]

Patchset 4 (id:??) landed as
https://crrev.com/45181af517b696b9495ad8639a5ac7d0212f2280
Cr-Commit-Position: refs/heads/master@{#310761}