Remove use_additional_auth column from logins table.

Remove use_additional_auth column from logins table from version 7.

During migration to newest versions use_additional_auth column
should be removed form logins database. Since sqllite syntax doesn't
support column dropping, so we create new database without this column
and copy data there.

BUG=423716
R=gcasto@chromium.org

Committed: https://crrev.com/8af63e57aadf4e35d5f3fbf38e7cc347a3331bac
Cr-Commit-Position: refs/heads/master@{#311443}

[melandory, 2015-01-05 10:57:24]

Patchset #1 (id:1) has been deleted

[melandory, 2015-01-05 11:01:09]

Patchset #1 (id:20001) has been deleted

[Garrett Casto, 2015-01-06 21:48:16]

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:261: // Remove
use_additional_auth column from database schema
This shouldn't be here, you need to increment the version number again.
Otherwise users that have already been upgraded will still have the column
around.

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:271: auto
copy_data_from_to_query =
I would just call this "copy_data_query". I can see why you're trying to be more
descriptive, but the name feels awkward.

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:275: };
Nit: Whitespace here.

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:285:
!db_.Execute("DROP TABLE logins_data"))
You need to recreate the index on logins as well.

[melandory, 2015-01-13 12:51:15]

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:261: // Remove
use_additional_auth column from database schema
On 2015/01/06 21:48:16, Garrett Casto wrote:
> This shouldn't be here, you need to increment the version number again.
> Otherwise users that have already been upgraded will still have the column
> around.

Done.

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:271: auto
copy_data_from_to_query =
On 2015/01/06 21:48:16, Garrett Casto wrote:
> I would just call this "copy_data_query". I can see why you're trying to be
more
> descriptive, but the name feels awkward.

Done.

https://codereview.chromium.org/818443004/diff/40001/components/password_mana...
components/password_manager/core/browser/login_database.cc:275: };
On 2015/01/06 21:48:16, Garrett Casto wrote:
> Nit: Whitespace here.

Done.

[melandory, 2015-01-13 13:31:14]

Patchset #4 (id:100001) has been deleted

[Garrett Casto, 2015-01-13 21:53:08]

lgtm

https://codereview.chromium.org/818443004/diff/120001/components/password_man...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/818443004/diff/120001/components/password_man...
components/password_manager/core/browser/login_database.cc:298:
"blacklisted_by_user, "
Any reason why this line is so short?

[melandory, 2015-01-14 08:47:10]

https://codereview.chromium.org/818443004/diff/120001/components/password_man...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/818443004/diff/120001/components/password_man...
components/password_manager/core/browser/login_database.cc:298:
"blacklisted_by_user, "
On 2015/01/13 21:53:08, Garrett Casto wrote:
> Any reason why this line is so short?

git cl format decided so =)

[melandory, 2015-01-14 09:05:44]

https://codereview.chromium.org/818443004/diff/120001/components/password_man...
File components/password_manager/core/browser/login_database.cc (right):

https://codereview.chromium.org/818443004/diff/120001/components/password_man...
components/password_manager/core/browser/login_database.cc:298:
"blacklisted_by_user, "
On 2015/01/14 08:47:10, melandory wrote:
> On 2015/01/13 21:53:08, Garrett Casto wrote:
> > Any reason why this line is so short?
> 
> git cl format decided so =)

Oh, nope. It was me. Will format it better.

[melandory, 2015-01-14 09:05:47]

The CQ bit was checked by melandory@chromium.org

[commit-bot: I haz the power, 2015-01-14 09:06:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818443004/140001

[commit-bot: I haz the power, 2015-01-14 10:12:57]

Committed patchset #5 (id:140001)

[commit-bot: I haz the power, 2015-01-14 10:13:59]

Patchset 5 (id:??) landed as
https://crrev.com/8af63e57aadf4e35d5f3fbf38e7cc347a3331bac
Cr-Commit-Position: refs/heads/master@{#311443}