Issue 818443003: Fix crash in observatory: stub code do not have inlined intervals information.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 818443003: Fix crash in observatory: stub code do not have inlined intervals information. (Closed)

Created:
6 years ago by srdjan

Modified:
6 years ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix crash in observatory: stub code do not have inlined intervals information. Added more comments to inline cache stub code. Committed: https://code.google.com/p/dart/source/detail?r=42547

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
M	runtime/vm/object.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stub_code_x64.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

srdjan

6 years ago (2014-12-22 13:24:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r42547 (presubmit successful).