Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 818443002: Enable display list 2D canvas by default (Closed)

Created:
6 years ago by Justin Novosad
Modified:
6 years ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable display list 2D canvas by default With this change, display list 2D canvas will become enabled by default in Chrome. Content shell with --dump-render-tree will continue to have display lists disabled by default. Currently, having display lists enabled in blink means that display lists will be used whenever 2d canvases would not be GPU-accelerated. BUG=386601 Committed: https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae Cr-Commit-Position: refs/heads/master@{#309453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M content/child/runtime_features.cc View 1 chunk +6 lines, -9 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
Justin Novosad
PTAL
6 years ago (2014-12-18 18:20:34 UTC) #2
Avi (use Gerrit)
lgtm
6 years ago (2014-12-18 19:42:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818443002/1
6 years ago (2014-12-18 20:02:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-18 20:57:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f98a302c6231cd607bb64eeadc5233ca858e3e8e Cr-Commit-Position: refs/heads/master@{#309069}
6 years ago (2014-12-18 20:58:02 UTC) #7
fmeawad
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/814163002/ by fmeawad@chromium.org. ...
6 years ago (2014-12-19 00:51:27 UTC) #8
Justin Novosad
blink_perf.canvas test was fixed in Blink to make it compatible with asynchronous rendering. This change ...
6 years ago (2014-12-22 20:25:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818443002/1
6 years ago (2014-12-22 20:26:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 20:27:40 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1546f423005338aac5961415bbfc48c61dc183ae Cr-Commit-Position: refs/heads/master@{#309453}
6 years ago (2014-12-22 20:28:31 UTC) #13
pfeldman
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/824063002/ by pfeldman@chromium.org. ...
5 years, 12 months ago (2014-12-24 15:30:04 UTC) #14
falken
5 years, 11 months ago (2015-01-07 08:36:17 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/832083003/ by falken@chromium.org.

The reason for reverting is: WebKit XP bot has lots of LayoutTest failures and
crashes in virtual/display_list_2d_canvas and virtual/gpu/fast/canvas.

See eg:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16116

The commit log suggests --dump-render-tree is
not affected by this change, but I don't see
another likely culprit (unless
https://src.chromium.org/viewvc/blink?view=rev&revision=187932)

The failures started on:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/16113

Chrome revision range:
https://chromium.googlesource.com/chromium/src/+log/5b35ed504ba27664bc0b7d732...

Blink revision range:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?u....

Powered by Google App Engine
This is Rietveld 408576698