chrome/common/pref_names.cc - Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/pref_names.cc

Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test and formatted browser_options.html. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/options/browser_options_handler.cc ('K') | « chrome/common/pref_names.h ('k') | chrome/test/data/policy/policy_test_cases.json » ('j') | components/policy/resources/policy_templates.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/pref_names.cc

diff --git a/chrome/common/pref_names.cc b/chrome/common/pref_names.cc

index 0467d5a38034b1494498ebde830b931859c1f441..f5ea05eae46c9dc66ead6548d009bdf450b2b96f 100644

--- a/chrome/common/pref_names.cc

+++ b/chrome/common/pref_names.cc

@@ -839,6 +839,11 @@ const char kTouchVirtualKeyboardEnabled[] = "ui.touch_virtual_keyboard_enabled";

// enabled.

const char kWakeOnWiFiEnabled[] = "settings.internet.wake_on_wifi";

+// This is policy CaptivePortalAuthenticationIgnoresProxy that allows to open

bartfab (slow) 2015/01/07 17:38:43 Nit: s/is/is the/

Alexander Alekseev 2015/01/12 18:41:10 Done.

+// Captive Portal authentication page in a separate window under another

bartfab (slow) 2015/01/07 17:38:43 Nit: s/page/pages/

Alexander Alekseev 2015/01/12 18:41:09 Done.

+// profile, which allows to bypass proxy for captive portal authentication.

bartfab (slow) 2015/01/07 17:38:43 What is this "another profile"? Some other user's

Alexander Alekseev 2015/01/12 18:41:10 Done.

+const char kCaptivePortalAuthenticationIgnoresProxy[] =

+ "proxy.captive_portal_ignores_proxy";

#endif // defined(OS_CHROMEOS)

// The disabled messages in IPC logging.