chrome/browser/chromeos/preferences.cc - Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/preferences.cc

Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed test and formatted browser_options.html. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/net/network_portal_notification_controller.cc ('K') | « chrome/browser/chromeos/net/network_portal_notification_controller.cc ('k') | chrome/browser/policy/configuration_policy_handler_list_factory.cc » ('j') | chrome/browser/ui/webui/options/browser_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/preferences.cc

diff --git a/chrome/browser/chromeos/preferences.cc b/chrome/browser/chromeos/preferences.cc

index 6ab83e2f9f6e41b19920cf30e8dc5a7434cfd1d1..aa44138a404b459aa98ea0c23dbc94af08a88d95 100644

--- a/chrome/browser/chromeos/preferences.cc

+++ b/chrome/browser/chromeos/preferences.cc

@@ -321,6 +321,10 @@ void Preferences::RegisterProfilePrefs(

user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

input_method::InputMethodSyncer::RegisterProfilePrefs(registry);

+ registry->RegisterBooleanPref(

+ prefs::kCaptivePortalAuthenticationIgnoresProxy, true,

bartfab (slow) 2015/01/07 17:38:43 Why is the default value |true|? According to poli

Alexander Alekseev 2015/01/12 18:41:09 Because this is shared preference, i.e. controlled

+ user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);

}

void Preferences::InitUserPrefs(PrefServiceSyncable* prefs) {