Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3003)

Unified Diff: chrome/browser/chromeos/net/network_portal_notification_controller.h

Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_portal_notification_controller.h
diff --git a/chrome/browser/chromeos/net/network_portal_notification_controller.h b/chrome/browser/chromeos/net/network_portal_notification_controller.h
index 1d279af90f09185193793ab7f505cbd1d043f291..9e4eb8c1a5ff32e374d0e6a0eafc98e149aa3517 100644
--- a/chrome/browser/chromeos/net/network_portal_notification_controller.h
+++ b/chrome/browser/chromeos/net/network_portal_notification_controller.h
@@ -56,6 +56,13 @@ class NetworkPortalNotificationController
// NULLifies reference to the active dialog.
void OnDialogDestroyed(const NetworkPortalWebDialog* dialog);
+ // Ignores "No network" errors in browser tests.
+ void SetIgnoreNoNetworkForTesting();
+
+ // Browser tests should be able to verify that NetworkPortalWebDialog is
+ // shown.
+ const NetworkPortalWebDialog* GetDialogForTesting() const;
+
private:
// Last network path for which notification was displayed.
std::string last_network_path_;
@@ -63,6 +70,9 @@ class NetworkPortalNotificationController
// Currently displayed authorization dialog, or NULL if none.
NetworkPortalWebDialog* dialog_;
+ // Do not close Portal Login dialog on "No network" error in browser tests.
+ bool ignore_no_network_for_testing_;
+
DISALLOW_COPY_AND_ASSIGN(NetworkPortalNotificationController);
};

Powered by Google App Engine
This is Rietveld 408576698