Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after review. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/options/browser_options_handler.h" 5 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 { "factoryResetDescription", IDS_OPTIONS_FACTORY_RESET_DESCRIPTION, 494 { "factoryResetDescription", IDS_OPTIONS_FACTORY_RESET_DESCRIPTION,
495 IDS_SHORT_PRODUCT_NAME }, 495 IDS_SHORT_PRODUCT_NAME },
496 #endif 496 #endif
497 { "languageSectionLabel", IDS_OPTIONS_ADVANCED_LANGUAGE_LABEL, 497 { "languageSectionLabel", IDS_OPTIONS_ADVANCED_LANGUAGE_LABEL,
498 IDS_SHORT_PRODUCT_NAME }, 498 IDS_SHORT_PRODUCT_NAME },
499 #if defined(ENABLE_SERVICE_DISCOVERY) 499 #if defined(ENABLE_SERVICE_DISCOVERY)
500 { "cloudPrintDevicesPageButton", IDS_LOCAL_DISCOVERY_DEVICES_PAGE_BUTTON }, 500 { "cloudPrintDevicesPageButton", IDS_LOCAL_DISCOVERY_DEVICES_PAGE_BUTTON },
501 { "cloudPrintEnableNotificationsLabel", 501 { "cloudPrintEnableNotificationsLabel",
502 IDS_LOCAL_DISCOVERY_NOTIFICATIONS_ENABLE_CHECKBOX_LABEL }, 502 IDS_LOCAL_DISCOVERY_NOTIFICATIONS_ENABLE_CHECKBOX_LABEL },
503 #endif 503 #endif
504 #if defined(OS_CHROMEOS)
505 { "captivePortalBypassProxy",
506 IDS_OPTIONS_CAPTIVE_PORTAL_BYPASS_PROXY_LABEL },
507 #endif
504 }; 508 };
505 509
506 #if defined(ENABLE_SETTINGS_APP) 510 #if defined(ENABLE_SETTINGS_APP)
507 static OptionsStringResource app_resources[] = { 511 static OptionsStringResource app_resources[] = {
508 { "syncOverview", IDS_SETTINGS_APP_SYNC_OVERVIEW }, 512 { "syncOverview", IDS_SETTINGS_APP_SYNC_OVERVIEW },
509 { "syncButtonTextStart", IDS_SYNC_START_SYNC_BUTTON_LABEL, 513 { "syncButtonTextStart", IDS_SYNC_START_SYNC_BUTTON_LABEL,
510 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME }, 514 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME },
511 { "profilesSingleUser", IDS_PROFILES_SINGLE_USER_MESSAGE, 515 { "profilesSingleUser", IDS_PROFILES_SINGLE_USER_MESSAGE,
512 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME }, 516 IDS_SETTINGS_APP_LAUNCHER_PRODUCT_NAME },
513 { "languageSectionLabel", IDS_OPTIONS_ADVANCED_LANGUAGE_LABEL, 517 { "languageSectionLabel", IDS_OPTIONS_ADVANCED_LANGUAGE_LABEL,
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 proximity_auth::switches::kEnableProximityDetection)); 650 proximity_auth::switches::kEnableProximityDetection));
647 651
648 #if defined(OS_CHROMEOS) 652 #if defined(OS_CHROMEOS)
649 values->SetBoolean( 653 values->SetBoolean(
650 "consumerManagementEnabled", 654 "consumerManagementEnabled",
651 CommandLine::ForCurrentProcess()->HasSwitch( 655 CommandLine::ForCurrentProcess()->HasSwitch(
652 chromeos::switches::kEnableConsumerManagement)); 656 chromeos::switches::kEnableConsumerManagement));
653 657
654 RegisterTitle(values, "thirdPartyImeConfirmOverlay", 658 RegisterTitle(values, "thirdPartyImeConfirmOverlay",
655 IDS_OPTIONS_SETTINGS_LANGUAGES_THIRD_PARTY_WARNING_TITLE); 659 IDS_OPTIONS_SETTINGS_LANGUAGES_THIRD_PARTY_WARNING_TITLE);
660
661 values->SetBoolean(
662 "enableCaptivePortalBypassProxyOption",
663 base::CommandLine::ForCurrentProcess()->HasSwitch(
664 chromeos::switches::kEnableCaptivePortalBypassProxyOption));
656 #endif 665 #endif
657 666
658 values->SetBoolean("showSetDefault", ShouldShowSetDefaultBrowser()); 667 values->SetBoolean("showSetDefault", ShouldShowSetDefaultBrowser());
659 668
660 values->SetBoolean("allowAdvancedSettings", ShouldAllowAdvancedSettings()); 669 values->SetBoolean("allowAdvancedSettings", ShouldAllowAdvancedSettings());
661 670
662 values->SetBoolean("websiteSettingsManagerEnabled", 671 values->SetBoolean("websiteSettingsManagerEnabled",
663 CommandLine::ForCurrentProcess()->HasSwitch( 672 CommandLine::ForCurrentProcess()->HasSwitch(
664 switches::kEnableWebsiteSettingsManager)); 673 switches::kEnableWebsiteSettingsManager));
665 674
(...skipping 1424 matching lines...) Expand 10 before | Expand all | Expand 10 after
2090 void BrowserOptionsHandler::OnPolicyUpdated(const policy::PolicyNamespace& ns, 2099 void BrowserOptionsHandler::OnPolicyUpdated(const policy::PolicyNamespace& ns,
2091 const policy::PolicyMap& previous, 2100 const policy::PolicyMap& previous,
2092 const policy::PolicyMap& current) { 2101 const policy::PolicyMap& current) {
2093 std::set<std::string> different_keys; 2102 std::set<std::string> different_keys;
2094 current.GetDifferingKeys(previous, &different_keys); 2103 current.GetDifferingKeys(previous, &different_keys);
2095 if (ContainsKey(different_keys, policy::key::kMetricsReportingEnabled)) 2104 if (ContainsKey(different_keys, policy::key::kMetricsReportingEnabled))
2096 SetupMetricsReportingCheckbox(); 2105 SetupMetricsReportingCheckbox();
2097 } 2106 }
2098 2107
2099 } // namespace options 2108 } // namespace options
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698