chrome/app/chromeos_strings.grdp - Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy.

Side by Side Diff: chrome/app/chromeos_strings.grdp

Issue 818433003: ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after review. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- ChromeOS-specific strings (included from generated_resources.grd).	2 <!-- ChromeOS-specific strings (included from generated_resources.grd).

3 Everything in this file is wrapped in <if expr="chromeos">. -->	3 Everything in this file is wrapped in <if expr="chromeos">. -->

4 <grit-part>	4 <grit-part>

5 <message name="IDS_EMPTY_STRING" desc="Empty string, exist only to make code g eneric. No translation required.">	5 <message name="IDS_EMPTY_STRING" desc="Empty string, exist only to make code g eneric. No translation required.">

6 </message>	6 </message>

7 <message name="IDS_CHROMEBOOK" desc="The localized name for Chromebook.">	7 <message name="IDS_CHROMEBOOK" desc="The localized name for Chromebook.">

8 Chromebook	8 Chromebook

9 </message>	9 </message>

10 <message name="IDS_CHROMEBOX" desc="The localized name for Chromebox">	10 <message name="IDS_CHROMEBOX" desc="The localized name for Chromebox">

(...skipping 5933 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
5944 </message>	5944 </message>

5945 <message name="IDS_SET_TIME_BUTTON_CLOSE" desc="Text for the button to close t he window.">	5945 <message name="IDS_SET_TIME_BUTTON_CLOSE" desc="Text for the button to close t he window.">

5946 Done	5946 Done

5947 </message>	5947 </message>

5948 <message name="IDS_SET_TIME_DATE_LABEL" desc="Label for the date input element .">	5948 <message name="IDS_SET_TIME_DATE_LABEL" desc="Label for the date input element .">

5949 System date	5949 System date

5950 </message>	5950 </message>

5951 <message name="IDS_SET_TIME_TIME_LABEL" desc="Label for the time input element .">	5951 <message name="IDS_SET_TIME_TIME_LABEL" desc="Label for the time input element .">

5952 System time	5952 System time

5953 </message>	5953 </message>

	5954 <message name="IDS_OPTIONS_CAPTIVE_PORTAL_BYPASS_PROXY_LABEL" desc="Option in chrome://settings that allows Captive Portal authorization pages to ignore proxy settings.">

	5955 Captive portal authorization bypasses proxy
	bartfab (slow) 2015/01/14 11:00:07 Are we actually sure that we want to expose this a Are we actually sure that we want to expose this as a user-adjustable option at all? Chrome tends to not expose tunables that are meaningless to the vast majority of users. A policy makes sense of course - but do we need a setting in the consumer case? Alexander Alekseev 2015/01/16 22:51:48 That's a good question. But I would leave the deci Show quoted text On 2015/01/14 11:00:07, bartfab wrote: > Are we actually sure that we want to expose this as a user-adjustable option at > all? Chrome tends to not expose tunables that are meaningless to the vast > majority of users. A policy makes sense of course - but do we need a setting in > the consumer case? That's a good question. But I would leave the decision to UI reviewers. If captive portal is behind proxy, this setting would allow to log in to portal. But I agree that this is a very rare and unusual case. bartfab (slow) 2015/01/21 10:09:56 Let's find out whether the UI folks want a setting Show quoted text On 2015/01/16 22:51:48, Alexander Alekseev wrote: > On 2015/01/14 11:00:07, bartfab wrote: > > Are we actually sure that we want to expose this as a user-adjustable option > at > > all? Chrome tends to not expose tunables that are meaningless to the vast > > majority of users. A policy makes sense of course - but do we need a setting > in > > the consumer case? > > That's a good question. But I would leave the decision to UI reviewers. > > If captive portal is behind proxy, this setting would allow to log in to portal. > But I agree that this is a very rare and unusual case. Let's find out whether the UI folks want a setting for this before we land one then.
	5956 </message>

5954 </grit-part>	5957 </grit-part>

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/about_flags.cc » ('j') | chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc » ('J')