ChromeOS: Implement CaptivePortalAuthenticationIgnoresProxy policy.

chrome/browser/policy/configuration_policy_handler_list_factory.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/memory/scoped_vector.h"
 #include "base/values.h"
@@ skipping 496 matching lines @@
   { key::kNativeMessagingUserLevelHosts,
     extensions::pref_names::kNativeMessagingUserLevelHosts,
     base::Value::TYPE_BOOLEAN },
   { key::kBrowserGuestModeEnabled,
     prefs::kBrowserGuestModeEnabled,
     base::Value::TYPE_BOOLEAN },
   { key::kBrowserAddPersonEnabled,
     prefs::kBrowserAddPersonEnabled,
     base::Value::TYPE_BOOLEAN },
 #endif  // !defined(OS_CHROMEOS) && !defined(OS_ANDROID) && !defined(OS_IOS)
+
+#if defined(OS_CHROMEOS)

[bartfab (slow), 2014/12/19 12:08:54]

There is a block for Chrome OS-specific policies already that ends in line 492.
You can just add your policy in there.

[Alexander Alekseev, 2014/12/22 22:20:11]

Done.

+  { key::kCaptivePortalAuthenticationIgnoresProxy,
+    prefs::kCaptivePortalAuthenticationIgnoresProxy,
+    base::Value::TYPE_INTEGER },

[bartfab (slow), 2014/12/19 12:08:54]

Since this is actually an int-enum, you should use a ConfigurationPolicyHandler
that checks whether the value is in the right range. However, as mentioned in my
comments for policy_templates.json, I think it would be best to turn this into a
boolean policy anyway.

[Alexander Alekseev, 2014/12/22 22:20:11]

I've added IntRangePolicyHandler for the new preference.

Also, please see my comments below.

+#endif  // defined(OS_CHROMEOS)
 };
 
 #if defined(ENABLE_EXTENSIONS)
 void GetExtensionAllowedTypesMap(
     ScopedVector<StringMappingListPolicyHandler::MappingEntry>* result) {
   // Mapping from extension type names to Manifest::Type.
   for (size_t index = 0;
        index < extensions::schema_constants::kAllowedTypesMapSize;
        ++index) {
     const extensions::schema_constants::AllowedTypesMapEntry& entry =
@@ skipping 291 matching lines @@
           chrome_schema,
           SCHEMA_STRICT,
           SimpleSchemaValidatingPolicyHandler::RECOMMENDED_ALLOWED,
           SimpleSchemaValidatingPolicyHandler::MANDATORY_PROHIBITED)));
 #endif  // defined(OS_CHROMEOS)
 
   return handlers.Pass();
 }
 
 }  // namespace policy