Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: util/file/file_io_posix.cc

Issue 818433002: Add LoggingOpenFileFor{Read|Write} (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@scoped-handle-land
Patch Set: . Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « util/file/file_io.h ('k') | util/file/file_io_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 11 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12 // See the License for the specific language governing permissions and 12 // See the License for the specific language governing permissions and
13 // limitations under the License. 13 // limitations under the License.
14 14
15 #include "util/file/file_io.h" 15 #include "util/file/file_io.h"
16 16
17 #include <fcntl.h>
17 #include <unistd.h> 18 #include <unistd.h>
18 19
20 #include "base/files/file_path.h"
19 #include "base/logging.h" 21 #include "base/logging.h"
20 #include "base/numerics/safe_conversions.h" 22 #include "base/numerics/safe_conversions.h"
21 #include "base/posix/eintr_wrapper.h" 23 #include "base/posix/eintr_wrapper.h"
22 24
23 namespace { 25 namespace {
24 26
25 struct ReadTraits { 27 struct ReadTraits {
26 using VoidBufferType = void*; 28 using VoidBufferType = void*;
27 using CharBufferType = char*; 29 using CharBufferType = char*;
28 static ssize_t Operate(int fd, CharBufferType buffer, size_t size) { 30 static ssize_t Operate(int fd, CharBufferType buffer, size_t size) {
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 namespace crashpad { 69 namespace crashpad {
68 70
69 ssize_t ReadFile(FileHandle file, void* buffer, size_t size) { 71 ssize_t ReadFile(FileHandle file, void* buffer, size_t size) {
70 return ReadOrWrite<ReadTraits>(file, buffer, size); 72 return ReadOrWrite<ReadTraits>(file, buffer, size);
71 } 73 }
72 74
73 ssize_t WriteFile(FileHandle file, const void* buffer, size_t size) { 75 ssize_t WriteFile(FileHandle file, const void* buffer, size_t size) {
74 return ReadOrWrite<WriteTraits>(file, buffer, size); 76 return ReadOrWrite<WriteTraits>(file, buffer, size);
75 } 77 }
76 78
79 FileHandle LoggingOpenFileForRead(const base::FilePath& path) {
80 int fd = HANDLE_EINTR(open(path.value().c_str(), O_RDONLY));
81 PLOG_IF(ERROR, fd < 0) << "open " << path.value();
82 return fd;
83 }
84
85 FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
86 FileWriteMode mode,
87 bool world_readable) {
88 int flags = O_WRONLY | O_CREAT;
89 // kReuseOrCreate does not need any additional flags.
90 if (mode == FileWriteMode::kTruncateOrCreate)
91 flags |= O_TRUNC;
92 else if (mode == FileWriteMode::kCreateOrFail)
93 flags |= O_EXCL;
94
95 int fd = HANDLE_EINTR(
96 open(path.value().c_str(), flags, world_readable ? 0644 : 0600));
97 PLOG_IF(ERROR, fd < 0) << "open " << path.value();
98 return fd;
99 }
100
77 bool LoggingCloseFile(FileHandle file) { 101 bool LoggingCloseFile(FileHandle file) {
78 int rv = IGNORE_EINTR(close(file)); 102 int rv = IGNORE_EINTR(close(file));
79 PLOG_IF(ERROR, rv != 0) << "close"; 103 PLOG_IF(ERROR, rv != 0) << "close";
80 return rv == 0; 104 return rv == 0;
81 } 105 }
82 106
83 } // namespace crashpad 107 } // namespace crashpad
OLDNEW
« no previous file with comments | « util/file/file_io.h ('k') | util/file/file_io_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698