Add LoggingOpenFileFor{Read|Write}

util/file/file_io_posix.cc

 // Copyright 2014 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #include "util/file/file_io.h"
 
+#include <fcntl.h>
 #include <unistd.h>
 
+#include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/posix/eintr_wrapper.h"
 
 namespace {
 
 struct ReadTraits {
   using VoidBufferType = void*;
   using CharBufferType = char*;
   static ssize_t Operate(int fd, CharBufferType buffer, size_t size) {
@@ skipping 38 matching lines @@
 namespace crashpad {
 
 ssize_t ReadFile(FileHandle file, void* buffer, size_t size) {
   return ReadOrWrite<ReadTraits>(file, buffer, size);
 }
 
 ssize_t WriteFile(FileHandle file, const void* buffer, size_t size) {
   return ReadOrWrite<WriteTraits>(file, buffer, size);
 }
 
+FileHandle LoggingOpenFileForWrite(const base::FilePath& path,
+                                   FileWriteMode mode,
+                                   bool world_readable) {
+  int flags = O_WRONLY;

[Mark Mentovai, 2014/12/18 21:52:32]

This should be O_WRONLY | O_CREAT, because we always want to create the file
even if it doesn’t exist. The cases below should adapt accordingly.

[scottmg, 2014/12/18 22:12:44]

Done.

+  switch (mode) {
+    case FileWriteMode::kAppend:
+      // Nothing to add.
+      break;
+    case FileWriteMode::kCreate:
+      flags |= O_CREAT | O_TRUNC;
+      break;
+    case FileWriteMode::kCreateNew:
+      flags |= O_CREAT | O_EXCL;
+      break;
+  }
+  int fd = HANDLE_EINTR(
+      open(path.value().c_str(), flags, world_readable ? 0644 : 0600));
+  PLOG_IF(ERROR, fd < 0) << "open " << path.value();
+  return fd;
+}
+
+FileHandle LoggingOpenFileForRead(const base::FilePath& path) {
+  int fd = HANDLE_EINTR(open(path.value().c_str(), O_RDONLY));
+  PLOG_IF(ERROR, fd < 0) << "open " << path.value();
+  return fd;
+}
+
 bool LoggingCloseFile(FileHandle file) {
   int rv = IGNORE_EINTR(close(file));
   PLOG_IF(ERROR, rv != 0) << "close";
   return rv == 0;
 }
 
 }  // namespace crashpad