core/src/fxge/ge/fx_ge_linux.cpp - Issue 818363006: fix a few linux compilation warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxge/ge/fx_ge_linux.cpp

Issue 818363006: fix a few linux compilation warnings (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxge/ge/fx_ge_linux.cpp

diff --git a/core/src/fxge/ge/fx_ge_linux.cpp b/core/src/fxge/ge/fx_ge_linux.cpp

index ad0a70ab1ff91f12561ccd2b66a567f2ed12e924..af2dc4a14b8f228a34e654f055a0a7487e9e3663 100644

--- a/core/src/fxge/ge/fx_ge_linux.cpp

+++ b/core/src/fxge/ge/fx_ge_linux.cpp

@@ -163,6 +163,7 @@ static FX_INT32 _LinuxGetSimilarValue(int weight, FX_BOOL bItalic, int pitch_fam

if ((style & FXFONT_BOLD) == (weight > 400)) {

iSimilarValue += 16;

}

+ // TODO(tsepez): File BUG since 0x40 & x is never 1, for instance.

if ((style & FXFONT_ITALIC) == bItalic) {

iSimilarValue += 16;

}