Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1329)

Side by Side Diff: runtime/vm/flow_graph_compiler_arm64.cc

Issue 818343002: Do not clobber dead temp registers at RestoreLiveRegisters as it may destroy the content of the res… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 1443 matching lines...) Expand 10 before | Expand all | Expand 10 after
1454 for (intptr_t reg_idx = 0; reg_idx < kNumberOfCpuRegisters; ++reg_idx) { 1454 for (intptr_t reg_idx = 0; reg_idx < kNumberOfCpuRegisters; ++reg_idx) {
1455 Register reg = static_cast<Register>(reg_idx); 1455 Register reg = static_cast<Register>(reg_idx);
1456 if (locs->live_registers()->ContainsRegister(reg)) { 1456 if (locs->live_registers()->ContainsRegister(reg)) {
1457 __ Push(reg); 1457 __ Push(reg);
1458 } 1458 }
1459 } 1459 }
1460 } 1460 }
1461 1461
1462 1462
1463 void FlowGraphCompiler::RestoreLiveRegisters(LocationSummary* locs) { 1463 void FlowGraphCompiler::RestoreLiveRegisters(LocationSummary* locs) {
1464 #if defined(DEBUG)
1465 ClobberDeadTempRegisters(locs);
1466 #endif
1467 // General purpose registers have the highest register number at the 1464 // General purpose registers have the highest register number at the
1468 // lowest address. 1465 // lowest address.
1469 for (intptr_t reg_idx = kNumberOfCpuRegisters - 1; reg_idx >= 0; --reg_idx) { 1466 for (intptr_t reg_idx = kNumberOfCpuRegisters - 1; reg_idx >= 0; --reg_idx) {
1470 Register reg = static_cast<Register>(reg_idx); 1467 Register reg = static_cast<Register>(reg_idx);
1471 if (locs->live_registers()->ContainsRegister(reg)) { 1468 if (locs->live_registers()->ContainsRegister(reg)) {
1472 __ Pop(reg); 1469 __ Pop(reg);
1473 } 1470 }
1474 } 1471 }
1475 1472
1476 const intptr_t fpu_regs_count = locs->live_registers()->FpuRegisterCount(); 1473 const intptr_t fpu_regs_count = locs->live_registers()->FpuRegisterCount();
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
1830 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 1827 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
1831 __ PopDouble(reg); 1828 __ PopDouble(reg);
1832 } 1829 }
1833 1830
1834 1831
1835 #undef __ 1832 #undef __
1836 1833
1837 } // namespace dart 1834 } // namespace dart
1838 1835
1839 #endif // defined TARGET_ARCH_ARM64 1836 #endif // defined TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698