Issue 81833007: Remove unnecessary Border subclasses where we can achieve the same functionality

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 81833007: Remove unnecessary Border subclasses where we can achieve the same functionality (Closed)

Created:
7 years, 1 month ago by Peter Kasting

Modified:
7 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Remove unnecessary Border subclasses where we can achieve the same functionality without subclassing. BUG=none TEST=none R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236844

Patch Set 1 #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -215 lines)			Patch
M	chrome/browser/defaults.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/defaults.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/infobar_button_border.h	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/infobar_button_border.cc	View	1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/infobar_label_button_border.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/infobar_label_button_border.cc	View	1 chunk	+0 lines, -38 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_view.cc	View	5 chunks	+41 lines, -4 lines	1 comment	Download
M	chrome/browser/ui/views/profile_chooser_view.cc	View	2 chunks	+5 lines, -27 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/message_center/views/notifier_settings_view.cc	View	2 chunks	+15 lines, -34 lines	0 comments	Download
M	ui/views/controls/button/text_button.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/controls/button/text_button.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/views/touchui/touch_editing_menu.cc	View	2 chunks	+5 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/81833007/diff/1/chrome/browser/ui/views/infobars/infobar_view.cc File chrome/browser/ui/views/infobars/infobar_view.cc (right): https://codereview.chromium.org/81833007/diff/1/chrome/browser/ui/views/infobars/infobar_view.cc#newcode48 chrome/browser/ui/views/infobars/infobar_view.cc:48: }; // namespace nit: no ;

7 years, 1 month ago (2013-11-22 14:42:44 UTC) #2

Peter Kasting

7 years, 1 month ago (2013-11-22 22:25:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r236844 (presubmit successful).

Expand Messages | Collapse Messages