Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: Source/core/rendering/RenderBlock.cpp

Issue 81833005: [REGRESSION] Button cannot be clicked with text-indent : -99999999px after r143483. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Put new change into a random spot Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderBlock.cpp
diff --git a/Source/core/rendering/RenderBlock.cpp b/Source/core/rendering/RenderBlock.cpp
index 3da6c555ebdc58450e6d9cd315ffce4d38ffa06e..a6497c5300be24a87f28d42ba946575f7c4d9c59 100644
--- a/Source/core/rendering/RenderBlock.cpp
+++ b/Source/core/rendering/RenderBlock.cpp
@@ -1507,14 +1507,6 @@ void RenderBlock::computeOverflow(LayoutUnit oldClientAfterEdge, bool)
m_overflow->setLayoutClientAfterEdge(oldClientAfterEdge);
}
- // Allow our overflow to catch cases where the caret in an empty editable element with negative text indent needs to get painted.
- LayoutUnit textIndent = textIndentOffset();
- if (textIndent < 0) {
- LayoutRect clientRect(noOverflowRect());
- LayoutRect rectToApply = LayoutRect(clientRect.x() + textIndent, clientRect.y(), clientRect.width() - textIndent, clientRect.height());
- addContentsVisualOverflow(rectToApply);
- }
-
// Add visual overflow from box-shadow and border-image-outset.
addVisualEffectOverflow();
« no previous file with comments | « LayoutTests/fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698