LayoutTests/fast/events/click-with-large-negative-text-indent.html - Issue 81833005: [REGRESSION] Button cannot be clicked with text-indent : -99999999px after r143483.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/click-with-large-negative-text-indent.html

Issue 81833005: [REGRESSION] Button cannot be clicked with text-indent : -99999999px after r143483. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add a new layout test. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 function test()

	5 {

	6 if (window.testRunner) {

	7 testRunner.dumpAsText();
	tkent 2013/11/22 05:11:55 We should call dumpAsText earlier. e.g. <script> We should call dumpAsText earlier. e.g. <script> if (window.testRunner) testRunner.dumpAsText(); function test() [ ....
	8 testRunner.waitUntilDone();
	tkent 2013/11/22 05:11:55 Calling waitUntilDone() and noifyDone() in one fun Calling waitUntilDone() and noifyDone() in one function makes no sense. Please remove them. You don't need to wait anything in this case because click event is synchronous and the test will finish after the onload handler. Also, you don't need to start test in onload handler. Just putting the test script after the <button> should work.
	9 }

	10 if (window.eventSender) {

	11 var testEle = document.getElementById('testButton');

	12 eventSender.mouseMoveTo(testEle.offsetLeft+testEle.offsetWidth/2, testEl e.offsetTop+testEle.offsetHeight/2);
	tkent 2013/11/22 05:11:55 Need spaces around '+' and '/' Need spaces around '+' and '/'
	13 eventSender.mouseDown();

	14 eventSender.mouseUp();

	15 }

	16 testRunner.notifyDone();

	17 }

	18

	19 function btnClicked()

	20 {

	21 document.getElementById('output').innerHTML = "Button is clicked.";

	22 }

	23 </script>

	24 </head>

	25 <body onload="test()">

	26 <button id="testButton" style="text-indent: -99999999px;" href="#none" onclick=" btnClicked()" title="newWindow">Move</button>

	27 <p id="output">

	28 </p>

	29 </body>

	30 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/click-with-large-negative-text-indent-expected.txt » ('j') | no next file with comments »