Roll third_party/trace-viewer DEPS

Roll trace-viewer to 2a348ed4cbdf27a8c9f0431d34ecbabf66182f08

Roll src/third_party/trace-viewer 2a348ed:e323952

TBR=nduca,dsinclair

Committed: https://crrev.com/a915aa7eb5442c76901bca95132f116a3c003b09
Cr-Commit-Position: refs/heads/master@{#310081}

[RaviKasibhatla, 2014-12-24 12:19:56]

kphanee@chromium.org changed reviewers:
+ dsinclair@chromium.org, nduca@chromium.org

[RaviKasibhatla, 2014-12-24 12:20:08]

The CQ bit was checked by kphanee@chromium.org

[commit-bot: I haz the power, 2014-12-24 12:20:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818323004/20001

[commit-bot: I haz the power, 2014-12-24 12:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 12:20:39]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[RaviKasibhatla, 2014-12-24 12:21:25]

Traceviewer DEPS roll.

[dsinclair, 2014-12-24 13:53:15]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2014-12-24 13:53:15]

lgtm

[commit-bot: I haz the power, 2014-12-24 13:53:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818323004/20001

[commit-bot: I haz the power, 2014-12-24 14:26:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 14:26:43]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)

[RaviKasibhatla, 2014-12-25 06:00:07]

The CQ bit was checked by kphanee@chromium.org

[commit-bot: I haz the power, 2014-12-25 06:00:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818323004/20001

[commit-bot: I haz the power, 2014-12-25 06:05:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-25 06:05:52]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[RaviKasibhatla, 2014-12-25 06:22:20]

The CQ bit was checked by kphanee@chromium.org

[commit-bot: I haz the power, 2014-12-25 06:22:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818323004/20001

[commit-bot: I haz the power, 2014-12-25 06:28:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-25 06:28:09]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[RaviKasibhatla, 2014-12-25 18:56:53]

The CQ bit was checked by kphanee@chromium.org

[commit-bot: I haz the power, 2014-12-25 18:57:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818323004/20001

[commit-bot: I haz the power, 2014-12-25 21:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-25 21:45:07]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)

[r.kasibhatla, 2014-12-26 09:11:21]

The CQ bit was checked by r.kasibhatla@samsung.com

[commit-bot: I haz the power, 2014-12-26 09:12:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818323004/20001

[commit-bot: I haz the power, 2014-12-26 11:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-26 11:19:40]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)

[dsinclair, 2015-01-05 15:00:53]

It looks like this is failing to generate about tracing on windows for some
reason.

That will need to be investigated/fixed before this lands. Can you file a bug
with the crash stack in it please?

[nduca, 2015-01-06 06:25:34]

https://github.com/google/trace-viewer/commit/8f7c4aca03eca96a26dc083ee040df8...
should have fixed this

[r.kasibhatla, 2015-01-06 10:33:19]

The CQ bit was checked by r.kasibhatla@samsung.com

[r.kasibhatla, 2015-01-06 10:33:43]

On 2015/01/06 06:25:34, nduca wrote:
>
https://github.com/google/trace-viewer/commit/8f7c4aca03eca96a26dc083ee040df8...
> should have fixed this

Updated the rolling version to latest version - with nduca fix and trying to
commit again.

[commit-bot: I haz the power, 2015-01-06 10:33:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818323004/40001

[commit-bot: I haz the power, 2015-01-06 12:26:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-06 12:27:38]

Patchset 3 (id:??) landed as
https://crrev.com/a915aa7eb5442c76901bca95132f116a3c003b09
Cr-Commit-Position: refs/heads/master@{#310081}

[tonyg, 2015-01-06 19:56:17]

We're seeing presubmit failures like this:
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...

Any chance this roll could be related?

[dsinclair, 2015-01-06 20:33:04]

I'm guessing that's caused by the roll. Please revert and we can fix before
we re-roll.

dan



On Tue Jan 06 2015 at 2:56:18 PM <tonyg@chromium.org> wrote:

> We're seeing presubmit failures like this:
> http://build.chromium.org/p/tryserver.chromium.linux/
> builders/chromium_presubmit/builds/33431/steps/presubmit/logs/stdio
>
> Any chance this roll could be related?
>
> https://codereview.chromium.org/818323004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nduca, 2015-01-07 04:09:18]

Sorry folks, I've tbrd a fix for this: https://codereview.chromium.org/838443007

[danakj, 2015-01-09 23:51:49]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-01-09 23:51:49]

Looks like this caused the cc::Picture viewer to break, it just displays grey
now.

[danakj, 2015-01-09 23:52:05]

On 2015/01/09 23:51:49, danakj wrote:
> Looks like this caused the cc::Picture viewer to break, it just displays grey
> now.

(I bisected to this CL.)