Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 818283002: Fix chromecast_browser_test. (Closed)

Created:
6 years ago by derekjchow1
Modified:
6 years ago
Reviewers:
gunsch
CC:
chromium-reviews, gunsch+watch_chromium.org, lcwu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix chromecast_browser_test. Use correct browser context when creating web_contents. R=gunsch@chromium.org BUG= Committed: https://crrev.com/57372056895fabfb36e67b6c806420dff091213a Cr-Commit-Position: refs/heads/master@{#309596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chromecast/browser/test/chromecast_browser_test.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
derekjchow1
6 years ago (2014-12-23 21:40:51 UTC) #1
gunsch
lgtm
6 years ago (2014-12-23 21:48:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818283002/1
6 years ago (2014-12-23 22:01:21 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45395) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/28862)
6 years ago (2014-12-23 22:09:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818283002/1
6 years ago (2014-12-23 22:17:25 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/28679)
6 years ago (2014-12-23 22:24:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818283002/1
6 years ago (2014-12-23 22:37:44 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45422)
6 years ago (2014-12-23 22:46:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818283002/1
6 years ago (2014-12-23 23:32:05 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/45442)
6 years ago (2014-12-23 23:40:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818283002/1
6 years ago (2014-12-24 00:31:48 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-24 00:54:52 UTC) #21
commit-bot: I haz the power
6 years ago (2014-12-24 00:55:38 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/57372056895fabfb36e67b6c806420dff091213a
Cr-Commit-Position: refs/heads/master@{#309596}

Powered by Google App Engine
This is Rietveld 408576698