Add a test that is a repro case for bug 444945.

Add a test that is a repro case for bug 444945.

It's disabled, because we don't have a fix yet
(and I'm about to go on leave).

This required moving the WebContentsAddedObserver from
content_browser_test_utils.h->browser_test_utils.h. I took
the opportunity to RenderFrame-ify it slightly.

BUG=444945
Committed: https://crrev.com/7bb1c5c7cb8e145d5222d19f38df405aa6b73ed8
Cr-Commit-Position: refs/heads/master@{#309599}

[ncarter (slow), 2014-12-23 23:32:15]

nick@chromium.org changed reviewers:
+ nasko@chromium.org

[ncarter (slow), 2014-12-23 23:32:16]

Hi Nasko, please review

[nasko, 2014-12-23 23:44:05]

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager_browsertest.cc:215:
content::SetupCrossSiteRedirector(embedded_test_server());
nit: You don't need the content::SetupCrossSiteRedirector call as you use the
GetURL to get the proper cross-site URL.

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager_browsertest.cc:239:
tab1->GetMainFrame()->ExecuteJavaScript(base::ASCIIToUTF16("while(1);"));
Wouldn't it be flaky to send these two as separate JS scripts? What happens if
title3.html has completed loading before the while(1) arrives?

[ncarter (slow), 2014-12-23 23:54:42]

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager_browsertest.cc:215:
content::SetupCrossSiteRedirector(embedded_test_server());
On 2014/12/23 23:44:04, nasko (Out till 2015) wrote:
> nit: You don't need the content::SetupCrossSiteRedirector call as you use the
> GetURL to get the proper cross-site URL. 

Good call.

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager_browsertest.cc:239:
tab1->GetMainFrame()->ExecuteJavaScript(base::ASCIIToUTF16("while(1);"));
On 2014/12/23 23:44:04, nasko (Out till 2015) wrote:
> Wouldn't it be flaky to send these two as separate JS scripts? What happens if
> title3.html has completed loading before the while(1) arrives?

Because WebContentses are created on the UI thread, and we are on the UI thread,
it's not possible for the tab2 WebContents to be created until we run the
message loop, which doesn't happen until line 242, after both scripts have
happened. So I think the load can't even really get started until the while(1)
script msg is in the IPC queue. Does that make sense to you?

[ncarter (slow), 2014-12-23 23:55:05]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2014-12-23 23:55:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818263004/40001

[commit-bot: I haz the power, 2014-12-23 23:55:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-23 23:55:32]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[nasko, 2014-12-24 00:22:56]

The CQ bit was checked by nasko@chromium.org

[nasko, 2014-12-24 00:22:57]

lgtm

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
File chrome/browser/task_manager/task_manager_browsertest.cc (right):

https://codereview.chromium.org/818263004/diff/20001/chrome/browser/task_mana...
chrome/browser/task_manager/task_manager_browsertest.cc:239:
tab1->GetMainFrame()->ExecuteJavaScript(base::ASCIIToUTF16("while(1);"));
On 2014/12/23 23:54:42, ncarter wrote:
> On 2014/12/23 23:44:04, nasko (Out till 2015) wrote:
> > Wouldn't it be flaky to send these two as separate JS scripts? What happens
if
> > title3.html has completed loading before the while(1) arrives?
> 
> Because WebContentses are created on the UI thread, and we are on the UI
thread,
> it's not possible for the tab2 WebContents to be created until we run the
> message loop, which doesn't happen until line 242, after both scripts have
> happened. 

Yes, thanks for the explanation.

> So I think the load can't even really get started until the while(1)
> script msg is in the IPC queue. Does that make sense to you?

Yeah, makes sense. Though the load can start, since it happens on the IO thread
in the browser, but cannot really commit since the while(1) will lock up the UI
thread in the renderer. Neat!

[commit-bot: I haz the power, 2014-12-24 00:23:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/818263004/40001

[commit-bot: I haz the power, 2014-12-24 01:37:47]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-24 01:38:39]

Patchset 3 (id:??) landed as
https://crrev.com/7bb1c5c7cb8e145d5222d19f38df405aa6b73ed8
Cr-Commit-Position: refs/heads/master@{#309599}